Issue #1345600 by jazzitup, dmitrit, Oleksa, tiikeri: Pollfield 7.x-2.x-dev with support for EntityFieldQuery and bug fixes

Conflicts:
	pollfield.module

Removed some extra spacing, and improved a comment.

When a pollfield had more than one value, the defaults would not be
written to each one. This fixes that, while still keeping the single
value fields working smoothly.

When I fixed the fieldset labels for single pollfields, I broke the
fieldsets when there are multiple values per fieldset. This fixes that
and breaks the fieldset name generation out of the theme function into a
seperate function.

The fieldset on the node form used to all be called pollfield. This
isn't very useful and it ignores the title of the field itself. Changing
the value to the name of the field, will improve usability.

The MySQL type text does not allow a default, so one shouldn't be
supplied here. MaxF's patch fixes this.

I also removed the comment about defaults which is no longer relevant.

Manarth pointed out that the default value and the db table type were
mismatched in the install script. Set the default to 0 instead of '0'
which is a string, not an int.

A few database field descriptions were lacking. This is related to this
issue about a schema mismatch, but doesn't directly fix it.

We were trying to unserialize an array from the wrong place for the
pollfield settings. Changed the code to look at the right part of the
default values array to unserialize.

Improved some comments describing this process.

We were trying to unserialize an array from the wrong place for the
pollfield settings. Changed the code to look at the right part of the
default values array to unserialize.

Improved some comments describing this process.

Improved the description of how and when we check for default values for
the form buidling function.

Added some spaces between variable declarations
Cleaned up a comment

This simplifies the checking that determines the state of the default
values for the form. It also prevents the default values from overriding
the choices spelled out in the node edit, while still setting content
type defaults for an unedited pollfield.

Default values for pollfields were not loading on existing nodes where a
pollfield had been added. The default code was and probably still is a
pretty cludgy, but this at least gets things to a working start point.

- Improved comments
- Cleaned up spacing
- Removed devel functions
- Renamed variables for consitency and clarity
- Modified the logic, adding a loop in to set all of the default values
  for an edit or a add node process.

This is part of the work to fix the default bugs. This isn't complete
work right now. Just committing to memory in this test branch.

The user object wasn't accessible by all of the functions.
The default value for the number of fields wasn't getting set when a new
pollfield is created.

The array value was overwriting previous values in the form array.
The main function had no return value.

I was trying to use an object definition as an argument in the function.

Fixed some other style issues.

Form element definitions were being repeated several times. I added a
function that is called instead of lots of repetition.

Since form data only gets returned when the poll is active I moved th
active condition around the entire set of rules for this function. I
also was able to pull the active state out of the $element variable,
allowing me to remove the extraneous sql call.

Several more variables were set in this funcion that we didn't need.
Removed them.

Cleaning up spacing and eliminating extra variable names

The form state variable was spelled wrong, and the passed value was
being obliterated in the function. Reinstated the passed variable.

This variable was named in an old use. I renamed it to better reflect
what it is doing for us. The comment explains its use a bit more now.

The deleted form function was just passing the form request along to
another function with no modification, so I've eliminated it. Moved the
appropriate arguments to the real form function.

This function is only called in one place and only has one line, so I've
eliminated it and moved the form build command into the theme function.

When you added a new pollfield neighter active or innactive was set.
This checks for a default and if one doesn't exist, sets it to 1 (aka
active).