>  Only variables should be passed by reference task.hosting.inc:61

Herman van Rink authored Oct 16, 2017 and Herman van Rink committed Oct 16, 2017

Issue #2915508 by kienan, helmo: Automatic hosting aliases for domains containing a dash create domains that contain R-LDH labels

Issue #2912515: Allow editing of Platform Path on unverified platforms: Fix publish_path validator to work when node isn't new by converting to an #element_validate hook.

commit 863447fe4e4cb531e9f61b8792638d79b4c865ac
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Aug 31 15:37:13 2017 -0400

    Reverting accidental whitespace.

commit 81c92a67ef0f9f41c747c4dc381a2dadf4027128
Merge: e214bc7 5250e39
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Jul 26 13:35:53 2017 -0400

    Merge branch '7.x-3.x-devshop' into 7.x-3.x

commit e214bc752aefa38a3d03eb6684580e51e5e65345
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Jul 26 13:34:45 2017 -0400

    Adding a comment about the platform node saving.

commit 5250e397b3a16fca11fb0c798cd1234d9d728a78
Merge: 6aac845 ba75f2bd
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Jul 26 13:34:07 2017 -0400

    Merge branch '7.x-3.x' into 7.x-3.x-devshop

commit 6aac84512a318f54166f5b1c047251b0c17f7d65
Merge: 72b1262 43ab3b49
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue May 16 15:46:27 2017 -0400

    Merge branch '7.x-3.x' into 7.x-3.x-devshop

commit 72b1262d9ee881ed238e9d61ba205f8cab771f89
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue May 16 15:38:24 2017 -0400

    Removing docker services from the branch.

commit 2bfd1006
Merge: 76c1fde8 e0edc66c
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue May 16 15:29:55 2017 -0400

    Merge branch '7.x-3.x' into 7.x-3.8-devshop

commit 76c1fde8
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 18 14:50:07 2017 -0500

    Use _server_has_docker_services() to check if we should hook in.

commit 37b38973
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 18 14:49:46 2017 -0500

    Fix check for docker services... Aegir does not make this easy, every service is available on every server.

commit e07d4f01
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 18 14:48:54 2017 -0500

    Force replace @server_ in AEGIR_SERVER_NAME.

commit 55e23ca4
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 18 14:37:22 2017 -0500

    Locking down form username and password.

commit ad983ebc
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 18 12:18:11 2017 -0500

    Fixing name of module.

commit 238b331e
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 18 07:31:51 2017 -0500

    say a warning instead of throwing an error if hostmaster container ID is not found.

commit 5c1e1fe7
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 17 17:11:37 2017 -0500

    Holy cow that was easy! Adding a "Cache" service with "Varnish" implementation, loads tutum/varnish container, links to your http container automatically!

commit 588ccd20
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 16 16:36:21 2017 -0500

    Improving port form element descriptions.

commit 799d63a6
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 16 16:34:39 2017 -0500

    Improving the port form element description.

commit 735c0f42
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 16 16:32:17 2017 -0500

    Renaming the docker services.

commit 4030a44b
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 16 16:31:39 2017 -0500

    Commenting out service type for now.

commit d5e12379
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 16 16:30:30 2017 -0500

    Handle an empty mysql server port by not exposing it at all. We don't typically want externally available database servers.

commit 4fb50375
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 16 15:48:44 2017 -0500

    Adding hook_provision_config_variables_alter() to change http_port to 80.

commit e9e9f13a
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Feb 15 08:48:50 2017 -0500

    When running grant_host() to figure out what the IP addresses of the web servers are, check if we are checking server_master. If so, run "mysql" command directly instead of using docker exec.

commit 327161c6
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 17:19:13 2017 -0500

    Override generate_site_credentials so we can set the db_host to "db".

commit b7471680
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 17:06:58 2017 -0500

    If context is a site, don't wait for the db server.

commit 2cc051c7
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 16:28:52 2017 -0500

    Overriding grant_host with our own so we can exec with docker exec, not mysql.

commit 9a077544
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 16:13:55 2017 -0500

    Only override remote_host for server contexts.

commit 6efa0d31
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 14:55:12 2017 -0500

    We need parent::verify_server_cmd().

commit fbd73028
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 12:22:22 2017 -0500

    Don't bother overwriting mysql hostname in Provision_Service_db_mysql_docker.  hostingService_db_mysql_docker() will set it for us.  Keep the polling check for database, as we will still have to wait for the database container to initialize.

commit f059401e
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 12:07:09 2017 -0500

    Check if we can already reach the database container from hostmaster.  If not add it to the network.

commit 9c7d701e
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:33:43 2017 -0500

    Connect hostmaster container to the docker-compose cluster's network.

commit 605e3e58
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:33:36 2017 -0500

    Pass the hostmaster container ID to the task process.

commit 70cb9e00
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:23:51 2017 -0500

    Add a form element to store the hostmaster container ID.

commit 0ae02a09
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:19:20 2017 -0500

    Change docker-compose.yml file generation to v2

commit 898fa362
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:04:54 2017 -0500

    Only log mysqladmin ping output to debug logs.

commit 6c011005
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:04:17 2017 -0500

    Remove validate hook for db service so we can have a port with 0.

commit 0cb35a88
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:02:55 2017 -0500

    Adding deletion of the docker compose file.

commit 9f1a5504
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 11:01:20 2017 -0500

    Adding delete server hook. Kills and Removes containers!

commit fbf17f45
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 10:37:53 2017 -0500

    Adding symfony/process to composer.

commit 18d4ce0c
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 10:37:15 2017 -0500

    Make the command a variable since we use it twice.

commit 1d60dc18
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 10:31:24 2017 -0500

    On first run check for mysqladmin ping so we don't have to sleep for 3 seconds if we don't have to.

commit 43028d7f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 10:26:25 2017 -0500

    Relax on the messaging, this method runs a lot.

commit 3c4cc976
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 10:20:47 2017 -0500

    Implement the connect() method with docker exec!  Finally got this to work. There is a strange behavior where this doesn't work with docker-compose exec.

commit d5f53f81
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 08:52:12 2017 -0500

    Don't run connect() method if drush command is provision-save.

commit 1faa2749
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 08:23:12 2017 -0500

    unneeded whitespace

commit 561933cc
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 07:58:37 2017 -0500

    Adding a runProcess() method to the Docker service.

commit 3e05fb83
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 07:28:19 2017 -0500

    Removing debug logging.

commit 0c7599b7
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Feb 14 07:26:13 2017 -0500

    Implement init_server to override the DSN to use "localhost", for now...

commit 55942de3
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Feb 13 11:37:44 2017 -0500

    Link every service to http container, only when there is one.

commit b5a2346c
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Feb 13 11:36:34 2017 -0500

    Link every service to http container.

commit a9502111
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Feb 13 11:03:34 2017 -0500

    Add a pre-verify hook to run docker-compose up before the rest of the services initiate so they can connect.

commit 1c8a836f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Feb 13 11:03:00 2017 -0500

    Fix Docker compose ports syntax

commit c3b5e6dd
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Feb 13 10:41:50 2017 -0500

    Remove the MYSQL_ROOT_USER environment variable, it is not used.

commit 7a95624b
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Feb 13 10:30:01 2017 -0500

    Adding a "docker" service with a "compose" implementation:
     - Provision_Service_docker_compose (Provision/Service/docker.php) handles writing 'docker_compose_path' property to server context, then on server provision-verify, writes the docker-compose file (using Provision_Config_Docker_Compose) and calls `docker-compose up -d`.
     - Provision_Config_Docker_Compose (Provision/Config/Docker/Compose.php) handles writing the docker-compose.yml file by collecting docker-compose service snippets using dockerComposeService().
     - Service classes for Apache and MySQL are coded specifically for the containers they use. They specify their image, and their entire docker-compose service array, injecting dynamic content like port and volumes.

    Docker Compose is much better to use than `docker` command because we can always call 'docker-compose up', whether the containers exist or not. The command also automatically restarts containers whose configuration has changed.

commit 83c9593d
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 15:45:10 2017 -0500

    Remove debug messages.

commit 6ce2a0f0
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 15:41:34 2017 -0500

    Create a separate "getEnvironment" method to generate environment variables for http and db services. Add "environment" method to apache docker service as an example.

commit 039c2568
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 14:48:46 2017 -0500

    Renaming include file.

commit 077aa970
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 13:01:01 2017 -0500

    Adding composer.json and YML package.

commit 6f6912d5
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 12:58:43 2017 -0500

    Run docker-compose up on verify server.

commit d08004a2
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 12:58:22 2017 -0500

    Adding Compose.php class for generating a docker compose yml file.

commit 19cf2d50
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Feb 10 08:50:27 2017 -0500

    Moving Provision_Service_http_apache_docker class to hosting_docker folder.

commit 3dbf459f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Feb 9 09:10:13 2017 -0500

    initial commit of docker services for Aegir

commit c2f6b305
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sun Feb 5 08:47:33 2017 -0500

    Issue #2849795: Add a checkbox to the hosting queue daemon settings page for pausing the queue.

commit 995f69ed
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sun Feb 5 08:46:53 2017 -0500

    Issue #2849795: Change hosting queue daemon init message based on paused state.  Ensure global $conf is called so variable reloading works.

commit 368539d4
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Feb 4 17:03:25 2017 -0500

    Issue #2849795: Check a variable before running queued tasks, allowing users to pause the queue daemon.

commit 1f3bd378
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Jan 19 13:49:06 2017 -0500

    Issue #2845040: Allow task_args to be passed from `drush hosting-task` command by parsing extra arguments. Adding documentation to hook_drush_command

commit 128bb35c
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Jan 19 13:48:42 2017 -0500

    Issue #2845040: Allow task_args to be passed from `drush hosting-task` command by parsing extra arguments. Adding documentation to hook_drush_command

commit 3ad37754
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Jan 4 11:40:55 2017 -0500

    Issue #2828630: Add a drush option to allow optionally not forking task processes.

commit c2e53fe0
Merge: d18f8a6f 4da425e9
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Dec 21 15:18:30 2016 -0500

    Merge branch '2754069-decouple-install' into 7.x-3.8-devshop

commit d18f8a6f
Merge: 3f79e5be ea38ed35
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Dec 21 09:30:19 2016 -0500

    Merge branch '2824731-site-create-platform' into 7.x-3.8-devshop

commit 3f79e5be
Merge: 14bde1ab 6c21da10
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Dec 21 09:25:44 2016 -0500

    Merge branch '2824731-site-create-platform' into 7.x-3.8-devshop

commit 14bde1ab
Merge: 42ab7036 1048817e
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Dec 21 09:17:45 2016 -0500

    Merge branch '2824731-site-create-platform' into 7.x-3.8-devshop

commit 42ab7036
Merge: 7e0d972b e65c5406
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Dec 21 09:00:12 2016 -0500

    Merge branch '2824731-site-create-platform' into 7.x-3.8-devshop

commit 7e0d972b
Merge: 1f1e33ff 3d8cb0ea
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Wed Dec 21 08:27:59 2016 -0500

    Merge branch '2824731-site-create-platform' into 7.x-3.8-devshop

commit 1f1e33ff
Merge: f7ccf236 f40d7239
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Dec 8 09:05:49 2016 -0500

    Merge branch '2828630-hosting-queued-logs' into 7.x-3.8+devshop

commit f40d7239
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Dec 8 09:01:05 2016 -0500

    Issue #2828630: Use "delta" not "duration". "duration" is from DevShop.

commit 5ee33107
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Dec 8 08:37:35 2016 -0500

    Issue #2828630: Add $backend_options as the function argument so hosting-queued can use "interactive" and hosting-tasks can use "fork".

commit 97b2afca
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 12:31:23 2016 -0500

    Issue #2828630: Add duration to finished task message, and if task is executed in a forked process, change the message to "Launched task".

commit f7ccf236
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 12:31:23 2016 -0500

    Issue #2828630: Add duration to finished task message, and if task is executed in a forked process, change the message to "Launched task".

commit c03c4d11
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 11:34:56 2016 -0500

    Issue #2828630: Change "fork" options to "backend_options", and just pass directly to drush_invoke_process(). The hosting-queued command needs interactive, the hosting-tasks command needs "fork".

commit c6b3154f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 10:52:03 2016 -0500

    Issue #2828630: Improving docblocks.

commit 90449b1d
Merge: 1c6fe370 961a6434
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 10:50:45 2016 -0500

    merge fix

commit 961a6434
Merge: 93a8b48f 1b014afa
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 09:59:14 2016 -0500

    Merge branch '7.x-3.x' of git.drupal.org:project/hosting into 2828630-hosting-queued-logs

commit 93a8b48f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 09:58:54 2016 -0500

    Issue #2828630: Add a new function to execute a hosting task: hosting_task_execute();  Used by drush hosting-tasks and drush hosting-queued commands.

commit 112614bc
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 09:19:54 2016 -0500

    Issue #2828630: Improve hosting-tasks and hosting-queued logging by outputting the number of tasks found.

commit 1c6fe370
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Tue Dec 6 09:19:54 2016 -0500

    Issue #2828630: Improve hosting-tasks and hosting-queued logging by outputting the number of tasks found.

commit 5a10659d
Merge: 04115866 fb0e33a9
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sun Dec 4 13:32:33 2016 -0500

    Merge branch '2828630-hosting-queued-logs' of git.drupal.org:project/hosting into 7.x-3.8+devshop

commit 04115866
Merge: 8b821d3b 6dc31c3f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sun Dec 4 13:31:34 2016 -0500

    Merge branch '2823827-task-object-labels' of git.drupal.org:project/hosting into 7.x-3.8+devshop

commit 8b821d3b
Merge: 3fc6dbe2 1b014afa
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sun Dec 4 13:24:55 2016 -0500

    Merge branch '7.x-3.x' of git.drupal.org:project/hosting into 2754069-2824731-install-platform

commit 3fc6dbe2
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Dec 3 14:58:52 2016 -0500

    Issue #2824731: Add site node to log message.

commit 554714d1
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Dec 3 14:56:39 2016 -0500

    Issue #2824731: Fix the query to lookup the profile_name, and output a log message.

commit 20763707
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Dec 3 14:38:38 2016 -0500

    Issue #2824731: If site node 'profile' is empty and 'profile_name' is not, when a site task is loaded lookup the install profile package and save it to the site node.

commit 36e3a8c1
Merge: f497d1a7 36cd882a
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Mon Nov 28 15:41:17 2016 -0500

    Merge branch '2824731-site-create-platform' into 2754069-decouple-install

commit fb0e33a9
Author: Herman van Rink <rink@initfour.nl>
Date:   Thu Nov 24 13:53:58 2016 +0100

    Issue #2828630 by Jon Pugh, helmo: move this logging to common functions

commit f9596918
Author: Herman van Rink <rink@initfour.nl>
Date:   Thu Nov 24 13:33:23 2016 +0100

    Issue #2828630 by Jon Pugh, helmo: Make the log format more consistent ... trailing dot.

commit 8e134067
Merge: 93f10ee4 287973c2
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Nov 19 08:18:00 2016 -0500

    Merge branch '2828630-hosting-queued-logs' of git.drupal.org:project/hosting into 2828630-hosting-queued-logs

commit 93f10ee4
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Nov 19 07:50:08 2016 -0500

    Issue #2828630: Fixing bad call to dt();

commit 287973c2
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Sat Nov 19 07:50:08 2016 -0500

    Fixing bad call to dt();

commit 5e33629f
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Fri Nov 18 13:08:41 2016 -0500

    Issue #2828630: More verbose drush logs for drush hosting-tasks command. Shortening text.

commit 7fcb996c
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Nov 17 17:41:48 2016 -0500

    Issue #2828630: More verbose drush logs for drush hosting-tasks command

commit 54814740
Author: Jon Pugh <jon@thinkdrop.net>
Date:   Thu Nov 17 16:07:52 2016 -0500

    Issue #2828630: More verbose drush logs for drush hosting-tasks command

Issue #2754069 by Jon Pugh: Merge remote-tracking branch 'origin/2754069-decouple-install' into 7.x-3.x

Kienan Stewart authored Jun 29, 2017 and Herman van Rink committed Jun 29, 2017

Issue #2883695 by kienan: Users with the aegir client role not able to see their sites and platforms

git authored Jun 08, 2017 and Herman van Rink committed Jun 08, 2017

Issue #2857721 by kfolsom: "Accessible clients" and "Associate a client to this user" Missing from User Editing Page

Issue #2881425: Inject platform properties into site nodes: web_server, platform_path, platform_verified, and platform_status.