Skip to content
Commit 97f4c4db authored by Moshe Kaplan's avatar Moshe Kaplan
Browse files

Implementing LogicDesign comments:

1. You added functions inside the .info file. Those functions should go inside .module or .install files

2. When you define a class the file should be referenced on the .info file

3. On line 154 of .module the title should be inside the t() function

4. You are executing code directly on the module file, from line 234 to the end of the file. I've worked with some modules until now and I've never seen this. I'm quite sure you can find hooks to execute that code at the right moment.

5. line 236. drupal_set_html_head is a Drupal 6 function.
Your module is Drupal 7, do you need to test if that function exists ?
parent b90360e5
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment