Chris Jansen authored Jun 24, 2016 and Chris Jansen committed Jun 24, 2016

Issue #2694249 by legolasbo, tlyngej: "The value you selected is not a valid choice" error is thrown when using integer lists

Squashed commit of the following:

commit 678e72662babd01575e475f1482eb61c556beb64
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 29 23:35:24 2015 +0100

    Add test coverage for the newly added settings.

commit ac442bc88e34af5934ecc3ddbb8bd02e839af78a
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 29 23:21:37 2015 +0100

    Add sorting functionality with test coverage

commit cebab93ebcf0bcf874dcc0316c4efc130c22c6ff
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 29 21:50:12 2015 +0100

    Allow sorting to be configured trough the settings form

commit 224c16b822e9ead150a0483c501da747571742a1
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 29 21:49:42 2015 +0100

    Update schema

Squashed commit of the following:

commit 6166f60dc3887ec6d666502050b1d92aa0013f43
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Sun Dec 27 11:11:01 2015 +0100

    Add empty option for buttons element

    Add test coverage for added empty option

    Refactor tests to have a separate test class for each class being tested

commit 546263d7c2e7ca55735de65905a226bd39eaea32
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Thu Dec 24 16:24:24 2015 +0100

    Refactor and test changes to Buttons.php

commit d41d30e803b404d38222ec740f266f0be7a85480
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Wed Dec 23 11:57:35 2015 +0100

    Fix failing unittest

commit 94d9948d95943b97fc851ab3d9082fddb9d2024d
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Wed Dec 23 11:53:08 2015 +0100

    Add empty options to the buttons element.

commit 6f6c30e951e6f37f2cd8b23db9807dd858ede5ba
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Wed Dec 23 10:53:34 2015 +0100

    Remove unused method TestBase::selectAllOptions

commit 173c69035197a1d0bd2d3c3b2e5027ebf8f4e7af
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Wed Dec 23 10:53:04 2015 +0100

    Make tests fail as expected.

commit 303aa8ab3bb99fb19a1dfa1c05fad611d9497c9f
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Wed Dec 23 10:22:36 2015 +0100

    Fix some changes introduced in D8

commit 47b4f791c0eed34fc325fddb967fa837cf56e6a5
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Wed Dec 23 10:22:15 2015 +0100

    Add schema and adjust widgets accordingly

commit 0d5ab1d644f281ca43e570668ec634f43018fa54
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 22 20:17:37 2015 +0100

    Start porting empty option tests.

commit b667189fbc90379f5ddc4ef315b17cbb89724444
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 22 09:50:18 2015 +0100

    Add empty option to select elements.

Remove test default value for the other field.

This reverts commit a2809554.

Squashed commit of the following:

commit 9ebf27714844775a771315f7795082605b746ec4
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 15 23:33:05 2015 +0100

    Fix and extend unittests.

commit 06ab2b51f057a37b834865cc8cfd7337c4aa781e
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 15 23:03:07 2015 +0100

    Add hack to also support multiselect elements.

commit 3292bdcf2c85d3007a65c0fce76442588d8c4764
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 15 17:45:47 2015 +0100

    Add states for buttons widget

commit 01ccea1ec9654999c4b7209059a0ff49ad276247
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 15 17:02:01 2015 +0100

    Add states for select widget

commit c35190ff943e97d6780dddc2a27bc0b4f32ac3d7
Author: legolasbo <legolasbo@2480548.no-reply.drupal.org>
Date:   Tue Dec 15 16:42:04 2015 +0100

    Implement JS as a library.

Currently 100% coverage of src/Element and ~20% coverage of src/Plugin.

Widgets implementing SelectOrOtherWidgetBase have a high probability of having unique way to determine their available options. SelectOrOtherWidgetBase should therefor not be opinionated.

By doing so we can remove the custom constructor.