Issue #3279537 by loopy1492: Fix PHP 8 regressions. (fdac5229) · Commits · project / nodequeue · GitLab

Commit fdac5229 authored Aug 23, 2022 by

Jen Lampton

Issue #3279537 by loopy1492: Fix PHP 8 regressions.

parent 9aa54501

Hide whitespace changes

Inline Side-by-side

Karol Haltenberger @KarolH · Aug 28, 2022

@jenlampton isset() returns a boolean, so this condition will never be true.

There seems to be a mixup here. Unless I'm wrong, the warning mentioned in this issue was caused by line 509 in the 2.3 version, but was already fixed in 2.4 by this patch

Edited Aug 28, 2022 by Karol Haltenberger

@jenlampton **_isset()_** returns a boolean, so this condition will never be true. There seems to be a mixup here. Unless I'm wrong, the warning mentioned in [this issue](https://www.drupal.org/project/nodequeue/issues/3279537) was caused by [line 509 in the 2.3 version](https://git.drupalcode.org/project/nodequeue/-/blob/7.x-2.3/nodequeue.module#L509), but was [already fixed in 2.4](https://git.drupalcode.org/project/nodequeue/-/blob/7.x-2.4/nodequeue.module#L509) by [this patch](https://www.drupal.org/project/nodequeue/issues/3166454)

Please register or to comment