Apply patch from issue 2328203. Thanks to Drumm.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

It should depend on fasttoggle_node, not itself.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Use a temporary variable to avoid the dependency on a PHP 5.4
feature.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Update the name of the variable (not denied => undecided) and
remove a couple of words that were wrongly left in a previous edit.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Make comment and modr8 support depend on fasttoggle_node. They
could theoretically be separated, but it would require some
duplication of code. The user can always just not enable node
options they don't want.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

This patch adds support for a link having a set of allowed values
that is a subset of the possible values for the setting. This is
needed for toggling comments between disabled, read only and read
write. If comments for a node are disabled and Fasttoggle is set
up to not allow you to disable comments, an error was displayed
on the page. That's now fixed.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Make the code easier to understand by adding further comments
in the header for the function and renaming a variable from
sitewide to objectwide.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

The views code wasn't checking all the permissions it should. Rely
instead on fasttoggle_get_allowed_links having done the correct checks.
(It won't return the element if it's not allowed).

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Remove some unneeded lines and rely on fasttoggle_get_allowed_links
to do all the access checking and only provide the info we need.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Make the node type settings in fasttoggle forms distinguishable again.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Update the access checks for the modified API.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Add more commenting and ensure that if no function explicitly
allows access to a setting, we deny it. This was the other part
of the problem with the user status issue.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Remove the global variable by passing results back down the call
chain.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Rename fasttoggle_check_access_have_outcome to
fasttoggle_check_access in preparation for getting rid of the
global variable and passing the result back.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Make the meaning of the "We haven't decided yet" value clearer.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Correct the omission of code applying the per-node type settings
for access to links.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Simplify the inclusion of files within the project. The previous version
should be safe, but this is better.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Make the moderate toggle default to being disabled, like other
toggles.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Improve the support for upgrading from 7.x-1.2 by getting the
translation of setting names and values right and removing the need
for the backwards compatibility in the main code.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Rename the variables as necessary.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

The field fasttoggles don't know what kind of view is being built, so
the 'view' parameter isn't set. Default to rendering a full node view
when toggling these settings.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Commit the first version of the API documentation.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

If an access check function does multiple checks (ie multiple calls
to fasttoggle_deny_access_if and fasttoggle_allow_access_if), make
the first one that would set an outcome be the effective one, rather
than the last. This makes it consistent with the overall flow of logic
and what you'd intuitively expect.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Add a comment explaining what we're doing (ie seeking to update the
node content after a setting is toggled).

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Update documentation and shift the @file tag back up to the top in
fasttoggle.module.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

The fifth argument isn't always required. Don't add it if it's not
needed and make it optional in the menu config.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Don't check $type. Check the results for a profile2 section.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Give ourselves access to the view mode so the Ajax can replace
content on the page with the same view (ie not putting in a comments
form where there wasn't one, not switching a teaser for the full node).

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Remove some obsolete functions from fasttoggle_comment and
fasttoggle_field.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Rework the access control by having one central _allowed_links function
that iterates over the results of _available_links, calling functions
that have been lists in the config structure.

Functions may operate at the site-wide level, group level or the level
of an individual setting, and are provided parameters appropriate to
the level.

Each function should call either fasttoggle_deny_access_if() or
fasttoggle_allow_access_if(), providing the boolean result of an access
test as the sole argument. More than one test may be run in a function.

If the test(s) in a function return FALSE, access is neither allowed or
denied - following tests (if any) are given the opportunity to have
their say. If the test (and hence the parameter) is TRUE, any remaining
tests in that function will also be run, but none of the remaining tests
that would be applied will be run. The result will be the outcome for this
item and any children it has.

If all test run without any given a definite answer for or against, the
access to the toggle will be allowed.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Update the fasttoggle user module to match recent changes.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Change the condition from "only status" to "not $node->type".

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Remove an unused function and add comments to functions that need them.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Rename variables and functions recently moved from Fasttoggle Node to
Fasttoggle Comment.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>

Add a comment explaining that the node commenting field's access is
handled by fasttoggle_node, not fasttoggle_comment.

Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au>