Skip to content
  1. Nov 18, 2004
  3. Oct 27, 2004
    • Dries Buytaert's avatar
      · c3c4906b
      Dries Buytaert authored 
      - Patch #12096 by Axel: fixed problem with plurals for some languages.
      c3c4906b
  5. Oct 19, 2004
    • Dries Buytaert's avatar
      · 469b35bb
      Dries Buytaert authored 
      - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.

  Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
      469b35bb
  7. Oct 13, 2004
  9. Oct 12, 2004
  11. Oct 04, 2004
    • Dries Buytaert's avatar
      · 503c7845
      Dries Buytaert authored 
      - Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache.
      503c7845
  13. Sep 16, 2004
  15. Sep 15, 2004
    • Dries Buytaert's avatar
      · 3079ffea
      Dries Buytaert authored 
      - Made it possible for the i18n module to hook in.
      3079ffea
  17. Sep 09, 2004
  19. Aug 22, 2004
  21. Aug 21, 2004
    • Dries Buytaert's avatar
      · 47b72af6
      Dries Buytaert authored 
      - Patch #6809 by TDobes: fixed the textarea hook so WYSIWYG editors are made possible again.

  TODO: apply the documentation and htmlarea module patches.
      47b72af6
    • Dries Buytaert's avatar
      · 7736eb49
      Dries Buytaert authored 
      - Patch #10166 by jvandyk: bugfix: valid_url() believed that URLs with encoded spaces in them (eg. http://example.org/my%20file.html ) are not valid.
      7736eb49
    • Dries Buytaert's avatar
      · f311646b
      Dries Buytaert authored 
      - Patch #10195 by JonBob: bugfix: common.inc used the function ob_get_clean() which is only available in PHP >= 4.3.
      f311646b
  23. Aug 20, 2004
  25. Aug 18, 2004
    • Dries Buytaert's avatar
      · 83a739bd
      Dries Buytaert authored 
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  27. Aug 17, 2004
  29. Aug 12, 2004
    • Dries Buytaert's avatar
      · cea07eca
      Dries Buytaert authored 
      - Patch #6806 by UnConeD: prefixed form IDs with 'edit-' so they won't clash
  with other IDs.  Also makes things a tad more consistent.
      cea07eca
  31. Aug 11, 2004
    • Dries Buytaert's avatar
      · 1831e1b6
      Dries Buytaert authored 
      - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.

  The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).

  Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
      1831e1b6
  33. Aug 10, 2004
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored 
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.

Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
    • Steven Wittens's avatar
      #7646 and more: · 88221c2f
      Steven Wittens authored 
      - Users who have not edited their account yet would be reset to GMT rather than the sitewide timezone.
- Users who chose GMT (zero timezone) on a site with a non-zero timezone as default would have incorrect timezone.
      88221c2f
  35. Aug 06, 2004
  37. Aug 04, 2004
    • Dries Buytaert's avatar
      · a52cf829
      Dries Buytaert authored 
      - Patch #7458 by killes: conditionally include xmlrpc.inc.
      a52cf829
  39. Jul 29, 2004
    • Steven Wittens's avatar
      Fixing a rather nasty bug with page cache: · 6c73823b
      Steven Wittens authored 
      The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.

This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
*phew*
      6c73823b
  41. Jul 22, 2004
  43. Jul 21, 2004
  45. Jul 13, 2004
    • Dries Buytaert's avatar
      · 50d78e98
      Dries Buytaert authored 
      - Patch #9238 by JonBob: added code and Doxygen comments to common.inc and
  bootstrap.inc.
      50d78e98
  47. Jul 12, 2004
  49. Jul 11, 2004
    • Dries Buytaert's avatar
      · 323d9fe0
      Dries Buytaert authored 
      - Call 'exit' hook when drupal_goto() is called.  Also necessary for the
  devel.module.
      323d9fe0
  51. Jul 08, 2004
    • Dries Buytaert's avatar
      · 02ae1ce6
      Dries Buytaert authored 
      - Many form_ functions called theme('form_element') with the wrong parameters!

- Fixed order of parameters in form_checkboxes() (plural).
      02ae1ce6
  53. Jul 04, 2004
    • Dries Buytaert's avatar
      · fe2b3e7c
      Dries Buytaert authored 
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:

    * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
    • Dries Buytaert's avatar
      - Textarea's did not have error handling support yet. · f3aa8712
      Dries Buytaert authored
      f3aa8712
  55. Jul 02, 2004
    • Dries Buytaert's avatar
      · 9986cb36
      Dries Buytaert authored 
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
      9986cb36
  57. Jun 28, 2004
  59. Jun 21, 2004