and confirm_form()

itself.

coder_upgrade.db.inc: enhance coder_upgrade_insert_dbtng_statement() to properly insert statements; coder_upgrade.function.inc: enhance coder_upgrade_op_to_hook() to not use clone and to allow for more than one case statement with no body; tests/samples directory: update the input and expected test file: example.module.

coder_upgrade.call.inc:#878470: enhance #drupal_set_header_renamed to handle no parameters; coder_upgrade.function.inc: enhance #hook_load_signature to clean the parameter variable; coder_upgrade.list.inc: add routine entry for grammar parser; coder_upgrade.main.inc, coder_upgrade.module: implement settings for preserving array format and debug output by coder upgrade and grammar parser.

etc) per line.  See core.coder_review_ignores.txt for an example - just replace 'core'
with your module name.

false positives - added in multi-line review functionality, forward and back.

isn't sanitized on previous lines in the same function, should reduce false
positives.

#318763 by john morahan, stella
#752734 by john morahan, stella
#301552 by douggreen, stella

coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax; coder_upgrade.begin.inc: refactor call to coder_upgrade_convert_return() and associated callback; coder_upgrade.function.inc: enhance coder_upgrade_convert_op() to use new getParameterVariable() API function, refactor the convert return pattern of routines: coder_upgrade_convert_return(), coder_upgrade_convert_return_loop(), and coder_upgrade_callback_return_caseN(); tests/samples directory: update the input and expected test file: example.module.

coder_upgrade.api.php: update documentation to reflect the node being returned by getFunctionCalls(); coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax.

coder_upgrade.call.inc, coder_upgrade.main.inc: revise code to reflect change to PGPReader::getFunctionCalls() which now returns a list of nodes; coder_upgrade.call.inc: enhance #comment_node_url, #taxonomy_form_all, and #update_sql to utilize the node now returned by getFunctionCalls().

coder_upgrade.call.inc: #update_sql, #847914: drupal_get_form() upgrade routine fails when form callback has no parameters; coder_upgrade.function.inc; #837258: add T_ELSE_IF to condition check in coder_upgrade_convert_op(), #update_sql: changes to hook_update_N().

coder_upgrade.test: include function.inc needed by begin.inc; tests/samples directory: update the input and expected test file: example.module (in previous commit).

coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax (by duellj and adrian); coder_upgrade.call.inc: improve #drupal_set_title to only find calls to check_plain(), improve #user_load_multiple to handle inline comments in parameters; coder_upgrade.function.inc: #833972: conform doc_comment to Drupal standards for inserted hook_op functions, add a doc_comment to each function missing one.

coder_upgrade.call.inc: #db_is_active, #remove-drupal-urlencode, improve #user_load_multiple to not always change call to user_load_multiple().

coder_upgrade.call.inc: #taxonomy_form_all; coder_upgrade.function.inc: #node_form, #drupal_render_children; coder_upgrade.regex.inc: #block_tables_renamed, #fapi_changes.

coder_upgrade.main.inc: enhance cdp() to allow for a description; coder_upgrade.regex.inc: implement #taxonomy_tables; tests/samples directory: update the input and expected test file: example.module.

coder_upgrade.module: enable customization of the module conversion form steps (build, validate and submit); coder_upgrade.main.inc: include function reference in patch file (diff -up)

coder.module, coder_review.module, coder_upgrade.module: #776996, #824268: eliminate strict warning in coder_review_page(), #636608: move settings menu items to local task of Review, #824320: eliminate warnings when only one of the Review or Upgrade modules is enabled; coder_upgrade.test: #820140: undefined DEADWOOD_OLD

coder_upgrade.call.inc: Implement #db_column_exists, improve #file_set_status; coder_upgrade.regex.inc: Implement #watchdog_emerg.

coder_upgrade.begin.inc, coder_upgrade.call.inc: Implement #hook_forms_signature; coder_upgrade.function.inc: Implement #hook_forms_signature, #hook_load_signature, #hook-user-changes.

coder_upgrade.call.inc: #db_result (not documented), #no-synonyms-taxonomy, #node_load_multiple (by duellj with modifications); coder_upgrade.function.inc: Improve coder_upgrade_callback_theme() to handle empty array as arguments parameter; coder_upgrade.regex.inc (by duellj): #remove_FILE_STATUS_TEMPORARY.

coder_upgrade.begin.inc, coder_upgrade.call.inc: #765070: allow for a theme without variables; coder_upgrade.function.inc: Improve coder_upgrade_convert_op() to extract the $op variable from the parameter, Improve coder_upgrade_callback_block to find quoted numeric deltas; coder_upgrade.install.inc: 765070: improve regex in convert_install_file_comment().

coder_upgrade.call.inc, coder_upgrade.regex.inc (by duellj with modifications): Implement #drupal_add_js_external, #jquery_ui, and #custom_block.