coder_upgrade.db.inc: enhance error handling by checking for conditions not being found in a select query; coder_upgrade.call.inc, coder_upgrade.function.inc: enhance #theme_changes to check number of parameters to theme_xxx() and hook_theme entry; coder_upgrade.function.inc: enhance #theme_changes when setting theme key to 'render element' also change value from an associative array to a string.

coder_upgrade.install: hook_uninstall(): delete recently added settings variables, hook_requirements(): use get_t().

coder_upgrade.function.inc: refactor #hook_permission to hook_upgrade_hook_perm_alter(), refactor #descriptions_permissions to use the convert_return() pattern (use cases 1 and 2), refactor doc_comment checking in coder_upgrade_convert_update_N() to revert to that in hook_upgrade_hook_alter(); tests/samples directory: update the input and expected test file: example.module.

coder_upgrade.inc: define file_directory_path() in response to its removal from core; coder_upgrade.db.inc, coder_upgrade.function.inc: coding style fixes.

coder_upgrade.function.inc: enhance #hook_filter_info (including a missed parser API change that broke the entire routine), #install-schema, #hook-user-changes, #hook_load_signature, and #theme_changes.

coder_upgrade.module: improve the menu integration when only Coder Upgrade is enabled, only allow the base files directory to be renamed, enable the submit handler for the settings form; coder_upgrade.main.inc: refactor the coder_upgrade_xxx_path() routines to reflect the coder_upgrade_dir variable.

and confirm_form()

itself.

coder_upgrade.db.inc: enhance coder_upgrade_insert_dbtng_statement() to properly insert statements; coder_upgrade.function.inc: enhance coder_upgrade_op_to_hook() to not use clone and to allow for more than one case statement with no body; tests/samples directory: update the input and expected test file: example.module.

coder_upgrade.call.inc:#878470: enhance #drupal_set_header_renamed to handle no parameters; coder_upgrade.function.inc: enhance #hook_load_signature to clean the parameter variable; coder_upgrade.list.inc: add routine entry for grammar parser; coder_upgrade.main.inc, coder_upgrade.module: implement settings for preserving array format and debug output by coder upgrade and grammar parser.

etc) per line.  See core.coder_review_ignores.txt for an example - just replace 'core'
with your module name.

false positives - added in multi-line review functionality, forward and back.

isn't sanitized on previous lines in the same function, should reduce false
positives.

#318763 by john morahan, stella
#752734 by john morahan, stella
#301552 by douggreen, stella

coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax; coder_upgrade.begin.inc: refactor call to coder_upgrade_convert_return() and associated callback; coder_upgrade.function.inc: enhance coder_upgrade_convert_op() to use new getParameterVariable() API function, refactor the convert return pattern of routines: coder_upgrade_convert_return(), coder_upgrade_convert_return_loop(), and coder_upgrade_callback_return_caseN(); tests/samples directory: update the input and expected test file: example.module.