Code refactoring: add conditions, reduce unnecessary code duplication, add usage of object methods in case of getting object properties.

Klaus Purer authored Dec 09, 2016 and Bryan Braun committed Dec 09, 2016

Issue #2825245 by klausi: Notice: Undefined index: class in writer_preprocess_block__system_branding_block()

Issue #2668440 by bryanbraun: Fix logo position by disabling contextual links for the branding block.

The extra padding was due to a CSS specificity error, but I also noticed
that the padding wasn't adjusting when the content-type chooses not to
display the publish date. That fix was included because it affects page
padding as well.

This also refactors writer_preprocess_page to use the attributes object,
which is more standard, and cleaner.

Also improves CSS by reducing unnecessary high-specificity.

Including:
  - Move default theme settings to config/install/writer.settings.yml
    (see also https://www.drupal.org/node/2382645)
  - Change the check_plain reference to Html::escape (see also
    https://www.drupal.org/node/2457593)
  - Change code-snippet CSS files into libraries (see also
    https://www.drupal.org/node/2379475)

Issue #2508697 by bryanbraun: Load styles/scripts properly using libraries, and make small visual adjustments.

It is unnecessary because version numbers are automatically added by
the Drupal.org packaging script when modules/themes are downloaded.

Issues #2367587 and #2329721 by IshaDakota: Fixed mechanism to load JS properly and fixed a Fatal error caused by drupal_add_html_head().

Issue #2201601 by bryanbraun: Replaced instaces of variable_get with calls to config. Also replaced hide() in twig templates and refactored CSS to load with renderable arrays.

Conflicts:
	writer.theme

Wesley De Vrient authored Dec 08, 2013 and Bryan Braun committed Dec 08, 2013

Issue #2131865 by wesleydv, bryanbraun: Adjusted page and comment templates to point to new timestamps.