Stefan Korn authored Sep 22, 2023 and Alexander Varwijk committed Sep 22, 2023

Issue #3075756 by stefan.korn, EnnoKirchhoff, BramDriesen, Kingdutch: Overall score indicator does not show color

This commit falls back to the default front-end theme by default, even
if content is edited within the context of the admin theme. It also
provides a per-form configuration to change this.

While we're doing the plumbing for the theme we do a similar plumbing
for the view mode which was an open todo. The default view mode is
changed from `full` to `default` since that's the Drupal default view
mode and `full` is not always available.

We can check our types and detect bugs this way. We fix some things from
lower levels but put everything above level 6 in the baseline. This
allows us to avoid changing large amounts of code but ensures new code
is checkt at the highest level.

This uses an up-to-date install of drupal/coder to fix coding standards
that were added. We also add a phpcs.xml configuration to make our lives
easier.

It's very useful to be able to inspect the state of a failing scenario
after the test has stopped. We already have tooling in our SetupContext
that will perform a fresh set-up for every scenario so there's no reason
for us to do post-test cleanup.

Issue #3204291 by MarcKwee, StryKaizer, batigolix, medwassim, BramDriesen: Call to undefined method Drupal\taxonomy\Entity\Term::getTitle()

This replaces the getTitle call which is specific to nodes with `label`.
Under the hood that is equivalent to calling `getTitle` for nodes but
for Term's the entity system ensures it's equivalent to callling
`getName`. By calling the `label` method we make use of the
`EntityInterface` which we already know we have so we don't need to
guess at methods using `method_exists`.

This reveals a bug which was file in #3204291 that Term's don't have a
`getTitle` method but generate the page title in some other way.

This configures GitLab CI to run the Behat tests included in the module.
Due to Drupal's project structure we do some composer and jq magic to
get the module with its dev dependencies installed in a vanilla Drupal
10 set-up that we pull from Docker.

This creates some tools for Behat so that we can create a node type in
the `testing` Drupal profile and then test that the widget behaves as
expected for a simple node.

This test can be extended in the future to cover various reported bugs
and integrations.

PHPUnit is not a great tool to write UI tests with. Drupal core has
Nightwatch but that's also not a tool the project maintainer is familiar
with.

Behat is a tool the maintainer is familiar with and allows us to
describe scenario's in human readable texts that can be discussed in
issues.

We add a Behat config that uses Chrome as well as some useful helpers to
get debug output in case of test failures as well as a way to easily
interface with Drupal.

The dependencies needed to run these tests are not added in the module
since some more infrastructure is needed. Instead those were added to
the development environment at https://github.com/Kingdutch/rtseo_dev

Vince Tikász authored Dec 17, 2022 and Alexander Varwijk committed Dec 17, 2022

Issue #3244677 by tikaszvince, gaurav-mathur, tim-diels, Kingdutch: Page not found after submitting an invalid form

Issue #3270799 by eyilmaz, Binoli Lalani, Johan den Hollander, quicksketch: Building preview entity fails for some field types (i.e. core date field)

Jeffrey Bertoen authored Dec 22, 2020 and Alexander Varwijk committed Dec 22, 2020

Issue #2992284 by mpp, jefuri, fabianderijk, olivier.br, Anybody, j3ll3nl, robinwest, alexfarr, damontgomery, barthje: Paragraphs fields not updated on node saving

Issue #3110455 by Kingdutch, Znak, jibran, c_archer: Metatags depending on URL cause errors for unsaved entities after updating to Drupal 8.8.0

Mario Vercellotti authored Oct 01, 2018 and Alexander Varwijk committed Oct 01, 2018

Issue #2980480 by vermario: Validation errors in forms are not really cleared when analysis is performed

Léon CROS authored Oct 01, 2018 and Alexander Varwijk committed Oct 01, 2018

Issue #2984590 by chipway, alonaoneill: Apply new {project}:{module} format for dependencies in info.yml

Alexander Varwijk authored Jun 03, 2018 and Alexander Varwijk committed Jun 03, 2018

Issue #2974301 by Kingdutch, emclaughlin: Yoast SEO Field Ajax Race Condition With Nested Paragraphs

Ruslan Piskarov authored Jun 03, 2018 and Alexander Varwijk committed Jun 03, 2018

Issue #2974202 by RuslanP, Ronak.addweb: Add a point to the end of the configuration menu item description

Instead of manually reading a YML file we now use the Drupal config
system to store the SEO scores. This makes it configurable and
easier to maintain.

This configuration is now also used by the javascript.

This commit removes some code that was used in earlier versions
that attempted to perform the new entity form submission. This is
now tackled by Form Handlers and solved in a better way.

Alexander Varwijk authored Apr 07, 2018 and Alexander Varwijk committed Apr 07, 2018

Issue #2941283 by Kingdutch, edurenye: Support context specific Metatags such as [current-page:title]