Sam Boyer authored Jun 20, 2012 and Marco Villegas committed Jun 29, 2012

Conflicts:

    includes/VersioncontrolGitRepository.php
      Minor conflict on sync() method that anyway will be removed soon.

Sam Boyer authored Jun 20, 2012 and Marco Villegas committed Jun 29, 2012

This commit introduces a whole new approach to rigorously testing
event-driven synchronization, via the VersioncontrolGitPushTests class.
Eventually, this testing class will likely supercede
VersioncontrolGitEventDataIntegrityTests entirely.

The test set is not yet complete, but TODOs are marked for the remaining
code paths to be tested, and a good example to follow has been clearly
set.

Sam Boyer authored Jun 20, 2012 and Marco Villegas committed Jun 29, 2012

This chases the corresponding interface addition on
VersioncontrolRepositoryHistorySynchronizerInterface in versioncontrol.

Sam Boyer authored Jun 19, 2012 and Marco Villegas committed Jun 29, 2012

1) When an incompatible event type is passed to syncEvent()
2) When syncing is about to be attempted on a non-valid Git repo
3) When the repo is locked and a sync is attempted. This throws
VersioncontrolLockedRepositoryException.

Sam Boyer authored Jun 19, 2012 and Marco Villegas committed Jun 29, 2012

This separation helps with readability a bit, and may also be a boon to
some API additions down the line.

Sam Boyer authored Jun 19, 2012 and Marco Villegas committed Jun 29, 2012

fetch*() is used to indicate repository interaction, load*() to indicate
database interaction.

Sam Boyer authored Jun 19, 2012 and Marco Villegas committed Jun 29, 2012

Also make the single-fetchers more robust vs. naming collisions, and fix
some minor docs/standards stuff.

Merge branch 'generic-reposync-follow-up' into 7.x-1.x

Removed the extra logic that attempted to minimize work for new branches
being added on push - just wasn't worth it.

Tests of pushes were creating confusing, impossible situations for
history synchronizers because the event was describing repository events
that did not actually happen, so fetching from the repo created
confusing results.

This change allows
VersioncontrolGitTestCase::versioncontrolSimulatePush() to write the
changes described in the push blob to the repository, so that history
synchronizers have a fully and properly mocked environment.

Instead of using versiocontrol label constans, so we can use other
reftypes in the future.

Now it's handled separately for each ref.

Git allows using the same string in different ref namespaces(i.e. a tag
and a branch can have the same name), so if someone happen to push a
pair of refs with the same name, at loading we will end up with one of
them instead of both.

- Assing the right value to {versioncontrol_git_event_data}.ff,
  considering adding and removing refs as fast-forward.
- Use and store commit hashes into
  {versioncontrol_git_event_data}.commits
- Change a lot the logic inside the syncEvent method to accept
  (hopefully) all possible scenarios, including updating the code to use