git authored Aug 24, 2017 and Herman van Rink committed Aug 24, 2017

Issue #2857480 by helmo, kfolsom, jsedwick: MySQL Dumps containing Global Transaction ID (GTID) Incompatible with Aegir

Jon Pugh authored Jul 13, 2017 and Herman van Rink committed Jul 13, 2017

Issue #2794915 by Jon Pugh: Refactor database permissions granting to allow scalability to arbitrary web servers

Issue #2794915: Allow database servers to grant access to all hosts. Creates a property on database servers called "db_grant_all_hosts". If set to true, grant_host_list() will return %, allowing access from any host.

Adam Andrzej Jaworski authored Sep 15, 2016 and Herman van Rink committed Sep 15, 2016

Issue #2798121 by memtkmcc: Manage extra db GRANT for 127.0.0.1 to allow SSH tunneling for remote SQL access (BOA unfork)

Issue #2475527: Catch additional DB connection failures, and provide more meaningful error messages.

we rewrite the dump code completely, stealing bits from
safe_shell_exec() for the DB credentials, to directly do the search
and replace of certain patterns ourselves. this simplifies the
pipeline and should also improve performance (because we avoid forking
sed twice), unless some memory leaks exist in PHP (which is quite
possible). we process the dump one line at a time so memory usage
shouldn't be higher.

the previous code would not catch errors from mysqldump because the
"sed" pipeline would succeed and therefore hide error from earlier in
the pipeline. we would need "set -o pipefail" in bash to workaround
this issue, but that is not portable and, let's be honest, there
already enough crap here as it is to warrant a cleanup.

previous attempt at fixing this issue (#2098289) are sometimes
unsuccesful because some dumps fail later than 1024 bytes. we still
keep that check just in case.

the bug (#1324466) was introduced in 571b63de, present since the 1.1
release.

this should be refactored to make safe_shell_exec() allow for a hook
to modify the dumpfile inline, but for now i just wanted to port a
working prototype in place.