diff --git a/core/modules/block/src/Tests/Views/DisplayBlockTest.php b/core/modules/block/src/Tests/Views/DisplayBlockTest.php index 92e7ddaf8cb7de11390e8a588619d5f34ac77b50..3c0deab0b97f4ae379602529eec2298f33322b34 100644 --- a/core/modules/block/src/Tests/Views/DisplayBlockTest.php +++ b/core/modules/block/src/Tests/Views/DisplayBlockTest.php @@ -275,8 +275,8 @@ public function testBlockContextualLinks() { $cached_block = $this->drupalPlaceBlock('views_block:test_view_block-block_1', array('cache' => array('max_age' => 3600))); $this->drupalGet('test-page'); - $id = 'block:block=' . $block->id() . ':|views_ui_edit:view=test_view_block:location=block&name=test_view_block&display_id=block_1'; - $cached_id = 'block:block=' . $cached_block->id() . ':|views_ui_edit:view=test_view_block:location=block&name=test_view_block&display_id=block_1'; + $id = 'block:block=' . $block->id() . ':|entity.view.edit_form:view=test_view_block:location=block&name=test_view_block&display_id=block_1'; + $cached_id = 'block:block=' . $cached_block->id() . ':|entity.view.edit_form:view=test_view_block:location=block&name=test_view_block&display_id=block_1'; // @see \Drupal\contextual\Tests\ContextualDynamicContextTest:assertContextualLinkPlaceHolder() $this->assertRaw(' $id)) . '>', format_string('Contextual link placeholder with id @id exists.', array('@id' => $id))); $this->assertRaw(' $cached_id)) . '>', format_string('Contextual link placeholder with id @id exists.', array('@id' => $cached_id))); @@ -287,8 +287,8 @@ public function testBlockContextualLinks() { $response = $this->drupalPost('contextual/render', 'application/json', $post, array('query' => array('destination' => 'test-page'))); $this->assertResponse(200); $json = Json::decode($response); - $this->assertIdentical($json[$id], ''); - $this->assertIdentical($json[$cached_id], ''); + $this->assertIdentical($json[$id], ''); + $this->assertIdentical($json[$cached_id], ''); } } diff --git a/core/modules/config_translation/src/ConfigEntityMapper.php b/core/modules/config_translation/src/ConfigEntityMapper.php index aa92fcdc13adeb65d8a50abfd5639d5f59109a2f..ce66ff670f7b3b2b7c228ba729561804285df0ae 100644 --- a/core/modules/config_translation/src/ConfigEntityMapper.php +++ b/core/modules/config_translation/src/ConfigEntityMapper.php @@ -232,7 +232,7 @@ public function getContextualLinkGroup() { case 'block': return $this->entityType; case 'view': - return 'views_ui_edit'; + return 'entity.view.edit_form'; default: return NULL; } diff --git a/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php index 253af4876c5fc5c4011512c5a733b1783500dc30..22bcaaf0db03aceb8d14c4e0afbc0e3c9cb43d74 100644 --- a/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php @@ -508,7 +508,7 @@ public function testViewsTranslationUI() { $this->drupalLogin($this->admin_user); // Assert contextual link related to views. - $ids = array('views_ui_edit:view=frontpage:location=page&name=frontpage&display_id=page_1'); + $ids = array('entity.view.edit_form:view=frontpage:location=page&name=frontpage&display_id=page_1'); $response = $this->renderContextualLinks($ids, 'node'); $this->assertResponse(200); $json = Json::decode($response); diff --git a/core/modules/contextual/src/Tests/ContextualDynamicContextTest.php b/core/modules/contextual/src/Tests/ContextualDynamicContextTest.php index 23d0666a3dfd9b538647fcc8ee1b83fd7dbe3130..61fa85e7f0f76c0ca354364b21f7524a14352d0a 100644 --- a/core/modules/contextual/src/Tests/ContextualDynamicContextTest.php +++ b/core/modules/contextual/src/Tests/ContextualDynamicContextTest.php @@ -60,7 +60,7 @@ function testDifferentPermissions() { 'node:node=' . $node1->id() . ':changed=' . $node1->getChangedTime(), 'node:node=' . $node2->id() . ':changed=' . $node2->getChangedTime(), 'node:node=' . $node3->id() . ':changed=' . $node3->getChangedTime(), - 'views_ui_edit:view=frontpage:location=page&name=frontpage&display_id=page_1', + 'entity.view.edit_form:view=frontpage:location=page&name=frontpage&display_id=page_1', ); // Editor user: can access contextual links and can edit articles. diff --git a/core/modules/views/src/Plugin/Block/ViewsBlockBase.php b/core/modules/views/src/Plugin/Block/ViewsBlockBase.php index fa8948783992252646aebaf3174d52e12d75ee0b..4736fbc9f8ec747290fa92d75880c69c1d8ab82e 100644 --- a/core/modules/views/src/Plugin/Block/ViewsBlockBase.php +++ b/core/modules/views/src/Plugin/Block/ViewsBlockBase.php @@ -152,7 +152,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta ); if ($this->view->storage->access('edit') && \Drupal::moduleHandler()->moduleExists('views_ui')) { - $form['views_label']['#description'] = $this->t('Changing the title here means it cannot be dynamically altered anymore. (Try changing it directly in @name.)', array('@url' => \Drupal::url('views_ui.edit_display', array('view' => $this->view->storage->id(), 'display_id' => $this->displayID)), '@name' => $this->view->storage->label())); + $form['views_label']['#description'] = $this->t('Changing the title here means it cannot be dynamically altered anymore. (Try changing it directly in @name.)', array('@url' => \Drupal::url('entity.view.edit_display_form', array('view' => $this->view->storage->id(), 'display_id' => $this->displayID)), '@name' => $this->view->storage->label())); } else { $form['views_label']['#description'] = $this->t('Changing the title here means it cannot be dynamically altered anymore.'); diff --git a/core/modules/views/src/Plugin/Menu/Form/ViewsMenuLinkForm.php b/core/modules/views/src/Plugin/Menu/Form/ViewsMenuLinkForm.php index 4eaf8c385693afcf094a3047ad40570321600c70..ac3aeff04bfb1ab8eee789e9e8bc83d24a38f5ad 100644 --- a/core/modules/views/src/Plugin/Menu/Form/ViewsMenuLinkForm.php +++ b/core/modules/views/src/Plugin/Menu/Form/ViewsMenuLinkForm.php @@ -61,7 +61,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta $id = $view->storage->id(); $label = $view->storage->label(); if ($this->moduleHandler->moduleExists('views_ui')) { - $message = $this->t('This link is provided by the Views module. The path can be changed by editing the view @label', array('@url' => \Drupal::url('views_ui.edit', array('view' => $id)), '@label' => $label)); + $message = $this->t('This link is provided by the Views module. The path can be changed by editing the view @label', array('@url' => \Drupal::url('entity.view.edit_form', array('view' => $id)), '@label' => $label)); } else { $message = $this->t('This link is provided by the Views module from view %label.', array('%label' => $label)); diff --git a/core/modules/views_ui/config/install/tour.tour.views-ui.yml b/core/modules/views_ui/config/install/tour.tour.views-ui.yml index af867be53300658c0e053c24d84c7e2119c14a2c..019866db3b67636928e598c92d31b21de88742b2 100644 --- a/core/modules/views_ui/config/install/tour.tour.views-ui.yml +++ b/core/modules/views_ui/config/install/tour.tour.views-ui.yml @@ -3,8 +3,8 @@ module: views_ui label: 'Views ui' langcode: en routes: - - route_name: views_ui.edit - - route_name: views_ui.edit_display + - route_name: entity.view.edit_form + - route_name: entity.view.edit_display_form tips: views-main: id: views-main diff --git a/core/modules/views_ui/src/Controller/ViewsUIController.php b/core/modules/views_ui/src/Controller/ViewsUIController.php index 013826621c0bce3acad421907d285ac1daab1e12..1acc52f74d904045047cfa9f2512ee4c8af611df 100644 --- a/core/modules/views_ui/src/Controller/ViewsUIController.php +++ b/core/modules/views_ui/src/Controller/ViewsUIController.php @@ -91,7 +91,7 @@ public function reportFields() { foreach ($fields as $field_name => $views) { $rows[$field_name]['data'][0] = String::checkPlain($field_name); foreach ($views as $view) { - $rows[$field_name]['data'][1][] = $this->l($view, 'views_ui.edit', array('view' => $view)); + $rows[$field_name]['data'][1][] = $this->l($view, 'entity.view.edit_form', array('view' => $view)); } $rows[$field_name]['data'][1] = SafeMarkup::set(implode(', ', $rows[$field_name]['data'][1])); } @@ -119,7 +119,7 @@ public function reportPlugins() { foreach ($rows as &$row) { // Link each view name to the view itself. foreach ($row['views'] as $row_name => $view) { - $row['views'][$row_name] = $this->l($view, 'views_ui.edit', array('view' => $view)); + $row['views'][$row_name] = $this->l($view, 'entity.view.edit_form', array('view' => $view)); } $row['views'] = SafeMarkup::set(implode(', ', $row['views'])); } diff --git a/core/modules/views_ui/src/Tests/DisplayTest.php b/core/modules/views_ui/src/Tests/DisplayTest.php index e38260341d1116a584801bac0ac16f6230040866..f451edf0a91ed429a150f0fc6488cfbf8fe42b99 100644 --- a/core/modules/views_ui/src/Tests/DisplayTest.php +++ b/core/modules/views_ui/src/Tests/DisplayTest.php @@ -91,13 +91,13 @@ public function testDisplayPluginsAlter() { $definitions = Views::pluginManager('display')->getDefinitions(); $expected = array( - 'route_name' => 'views_ui.edit', + 'route_name' => 'entity.view.edit_form', 'route_parameters_names' => array('view' => 'id'), ); // Test the expected views_ui array exists on each definition. foreach ($definitions as $definition) { - $this->assertIdentical($definition['contextual links']['views_ui_edit'], $expected, 'Expected views_ui array found in plugin definition.'); + $this->assertIdentical($definition['contextual links']['entity.view.edit_form'], $expected, 'Expected views_ui array found in plugin definition.'); } } @@ -175,7 +175,7 @@ public function testPageContextualLinks() { $view->enable()->save(); $this->drupalGet('test-display'); - $id = 'views_ui_edit:view=test_display:location=page&name=test_display&display_id=page_1'; + $id = 'entity.view.edit_form:view=test_display:location=page&name=test_display&display_id=page_1'; // @see \Drupal\contextual\Tests\ContextualDynamicContextTest:assertContextualLinkPlaceHolder() $this->assertRaw(' $id)) . '>', format_string('Contextual link placeholder with id @id exists.', array('@id' => $id))); @@ -185,7 +185,7 @@ public function testPageContextualLinks() { $response = $this->drupalPost('contextual/render', 'application/json', $post, array('query' => array('destination' => 'test-display'))); $this->assertResponse(200); $json = Json::decode($response); - $this->assertIdentical($json[$id], ''); + $this->assertIdentical($json[$id], ''); } /** diff --git a/core/modules/views_ui/src/ViewEditForm.php b/core/modules/views_ui/src/ViewEditForm.php index fd669c41b49bc6a2b8e0669622b4ac9421e33913..738a0874565996835d4e24d9e0a12e04dceea94d 100644 --- a/core/modules/views_ui/src/ViewEditForm.php +++ b/core/modules/views_ui/src/ViewEditForm.php @@ -141,7 +141,7 @@ public function form(array $form, FormStateInterface $form_state) { $lock_message_substitutions = array( '!user' => drupal_render($username), '!age' => $this->dateFormatter->formatInterval(REQUEST_TIME - $view->lock->updated), - '!break' => $view->url('break-lock'), + '!break' => $view->url('break-lock-form'), ); $form['locked'] = array( '#type' => 'container', @@ -296,7 +296,7 @@ public function submit(array $form, FormStateInterface $form_state) { unset($displays[$id]); // Redirect the user to the renamed display to be sure that the page itself exists and doesn't throw errors. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $new_id, )); @@ -592,7 +592,7 @@ public function submitDisplayUndoDelete($form, FormStateInterface $form_state) { $view->cacheSet(); // Redirect to the top-level edit page. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $id, )); @@ -611,7 +611,7 @@ public function submitDisplayEnable($form, FormStateInterface $form_state) { $view->cacheSet(); // Redirect to the top-level edit page. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $id, )); @@ -629,7 +629,7 @@ public function submitDisplayDisable($form, FormStateInterface $form_state) { $view->cacheSet(); // Redirect to the top-level edit page. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $id, )); @@ -708,7 +708,7 @@ public function renderDisplayTop(ViewUI $view) { ), 'duplicate' => array( 'title' => $this->t('Duplicate view'), - ) + $view->urlInfo('duplicate')->toArray(), + ) + $view->urlInfo('duplicate-form')->toArray(), 'reorder' => array( 'title' => $this->t('Reorder displays'), 'href' => "admin/structure/views/nojs/reorder-displays/{$view->id()}/$display_id", @@ -827,7 +827,7 @@ public function submitDisplayDuplicate($form, FormStateInterface $form_state) { $view->cacheSet(); // Redirect to the new display's edit page. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $new_display_id, )); @@ -849,7 +849,7 @@ public function submitDisplayAdd($form, FormStateInterface $form_state) { $view->cacheSet(); // Redirect to the new display's edit page. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $display_id, )); @@ -885,7 +885,7 @@ public function submitDuplicateDisplayAsType($form, FormStateInterface $form_sta $view->cacheSet(); // Redirect to the new display's edit page. - $form_state->setRedirect('views_ui.edit_display', array( + $form_state->setRedirect('entity.view.edit_display_form', array( 'view' => $view->id(), 'display_id' => $new_display_id, )); diff --git a/core/modules/views_ui/src/ViewListBuilder.php b/core/modules/views_ui/src/ViewListBuilder.php index 732171294d5ebeae3093ba3c87689a6506f8d5e6..16b5b8443145bd60b0da93bf45140b5c7df0913d 100644 --- a/core/modules/views_ui/src/ViewListBuilder.php +++ b/core/modules/views_ui/src/ViewListBuilder.php @@ -145,17 +145,17 @@ public function buildHeader() { public function getDefaultOperations(EntityInterface $entity) { $operations = parent::getDefaultOperations($entity); - if ($entity->hasLinkTemplate('duplicate')) { + if ($entity->hasLinkTemplate('duplicate-form')) { $operations['duplicate'] = array( 'title' => $this->t('Duplicate'), 'weight' => 15, - ) + $entity->urlInfo('duplicate')->toArray(); + ) + $entity->urlInfo('duplicate-form')->toArray(); } // Add AJAX functionality to enable/disable operations. foreach (array('enable', 'disable') as $op) { if (isset($operations[$op])) { - $operations[$op]['route_name'] = "views_ui.$op"; + $operations[$op]['route_name'] = "entity.view.{$op}"; $operations[$op]['route_parameters'] = array('view' => $entity->id()); // Enable and disable operations should use AJAX. diff --git a/core/modules/views_ui/src/ViewUI.php b/core/modules/views_ui/src/ViewUI.php index 588f3795fc5f41b3bb9b3c2e4c49fde9cb89ebb4..51e16b29079f0878371c5757b9e1b120610ffa0b 100644 --- a/core/modules/views_ui/src/ViewUI.php +++ b/core/modules/views_ui/src/ViewUI.php @@ -635,7 +635,7 @@ public function renderPreview($display_id, $args = array()) { $show_additional_queries = $config->get('ui.show.additional_queries'); - Timer::start('views_ui.preview'); + Timer::start('entity.view.preview_form'); if ($show_additional_queries) { $this->startQueryCapture(); @@ -649,7 +649,7 @@ public function renderPreview($display_id, $args = array()) { $this->endQueryCapture(); } - $this->render_time = Timer::stop('views_ui.preview'); + $this->render_time = Timer::stop('entity.view.preview_form'); views_ui_contextual_links_suppress_pop(); diff --git a/core/modules/views_ui/views_ui.links.contextual.yml b/core/modules/views_ui/views_ui.links.contextual.yml index 20e9ead0b3161418a950836cc54d23c1c2bbac36..90a2428ff0081e5d9e471f7be1533ece0bc8ec87 100644 --- a/core/modules/views_ui/views_ui.links.contextual.yml +++ b/core/modules/views_ui/views_ui.links.contextual.yml @@ -1,9 +1,9 @@ -views_ui.edit: +entity.view.edit_form: title: 'Edit view' - route_name: views_ui.edit - group: views_ui_edit + route_name: entity.view.edit_form + group: entity.view.edit_form -views_ui.preview: +entity.view.preview_form: title: 'Preview view' - route_name: views_ui.preview - group: views_ui_preview + route_name: entity.view.preview_form + group: entity.view.preview_form diff --git a/core/modules/views_ui/views_ui.links.task.yml b/core/modules/views_ui/views_ui.links.task.yml index 9ef586e0766f782ce4a529a9bb375bb603734147..c7fe8b00101f98f3117c8ea97d1716e0b761c7a9 100644 --- a/core/modules/views_ui/views_ui.links.task.yml +++ b/core/modules/views_ui/views_ui.links.task.yml @@ -24,7 +24,7 @@ views_ui.reports_fields: title: 'Used in views' base_route: field_ui.list -views_ui.edit: +entity.view.edit_form: title: 'Edit' - route_name: views_ui.edit - base_route: views_ui.edit + route_name: entity.view.edit_form + base_route: entity.view.edit_form diff --git a/core/modules/views_ui/views_ui.module b/core/modules/views_ui/views_ui.module index f22299eedb0ee03db54e2765676e2fe7474d26ab..3c9c234e88a680032f2c5a4efde69a9b30b1487b 100644 --- a/core/modules/views_ui/views_ui.module +++ b/core/modules/views_ui/views_ui.module @@ -51,14 +51,14 @@ function views_ui_entity_type_build(array &$entity_types) { ->setFormClass('delete', 'Drupal\views_ui\ViewDeleteForm') ->setFormClass('break_lock', 'Drupal\views_ui\Form\BreakLockForm') ->setListBuilderClass('Drupal\views_ui\ViewListBuilder') - ->setLinkTemplate('edit-form', 'views_ui.edit') - ->setLinkTemplate('edit-display-form', 'views_ui.edit_display') - ->setLinkTemplate('preview-form', 'views_ui.preview') - ->setLinkTemplate('duplicate', 'views_ui.duplicate') - ->setLinkTemplate('delete-form', 'views_ui.delete') - ->setLinkTemplate('enable', 'views_ui.enable') - ->setLinkTemplate('disable', 'views_ui.disable') - ->setLinkTemplate('break-lock', 'views_ui.break_lock'); + ->setLinkTemplate('edit-form', 'entity.view.edit_form') + ->setLinkTemplate('edit-display-form', 'entity.view.edit_display_form') + ->setLinkTemplate('preview-form', 'entity.view.preview_form') + ->setLinkTemplate('duplicate-form', 'entity.view.duplicate_form') + ->setLinkTemplate('delete-form', 'entity.view.delete_form') + ->setLinkTemplate('enable', 'entity.view.enable') + ->setLinkTemplate('disable', 'entity.view.disable') + ->setLinkTemplate('break-lock-form', 'entity.view.break_lock_form'); } /** @@ -223,8 +223,8 @@ function views_ui_views_plugins_display_alter(&$plugins) { // paths underneath "admin/structure/views/view/{$view->id()}" (i.e., paths // for editing and performing other contextual actions on the view). foreach ($plugins as &$display) { - $display['contextual links']['views_ui_edit'] = array( - 'route_name' => 'views_ui.edit', + $display['contextual links']['entity.view.edit_form'] = array( + 'route_name' => 'entity.view.edit_form', 'route_parameters_names' => array('view' => 'id'), ); } @@ -242,10 +242,10 @@ function views_ui_contextual_links_view_alter(&$element, $items) { // Append the display ID to the Views UI edit links, so that clicking on the // contextual link takes you directly to the correct display tab on the edit // screen. - elseif (!empty($element['#links']['views-uiedit'])) { - $display_id = $items['views_ui.edit']['metadata']['display_id']; - $element['#links']['views-uiedit']['route_parameters']['display_id'] = $display_id; - $element['#links']['views-uiedit']['route_name'] = 'views_ui.edit_display'; + elseif (!empty($element['#links']['entityviewedit-form'])) { + $display_id = $items['entity.view.edit_form']['metadata']['display_id']; + $element['#links']['entityviewedit-form']['route_parameters']['display_id'] = $display_id; + $element['#links']['entityviewedit-form']['route_name'] = 'entity.view.edit_display_form'; } } diff --git a/core/modules/views_ui/views_ui.routing.yml b/core/modules/views_ui/views_ui.routing.yml index b589d1721d08aa4b1aadbd2a67cc019a3a582ee2..9a36472ed0d9aab8ce548fa779221d5f48bf3009 100644 --- a/core/modules/views_ui/views_ui.routing.yml +++ b/core/modules/views_ui/views_ui.routing.yml @@ -46,7 +46,7 @@ views_ui.reports_plugins: requirements: _permission: 'administer views' -views_ui.enable: +entity.view.enable: path: '/admin/structure/views/view/{view}/enable' defaults: _controller: '\Drupal\views_ui\Controller\ViewsUIController::ajaxOperation' @@ -55,7 +55,7 @@ views_ui.enable: _entity_access: view.enable _csrf_token: 'TRUE' -views_ui.disable: +entity.view.disable: path: '/admin/structure/views/view/{view}/disable' defaults: _controller: '\Drupal\views_ui\Controller\ViewsUIController::ajaxOperation' @@ -64,7 +64,7 @@ views_ui.disable: _entity_access: view.disable _csrf_token: 'TRUE' -views_ui.duplicate: +entity.view.duplicate_form: path: '/admin/structure/views/view/{view}/duplicate' defaults: _entity_form: 'view.duplicate' @@ -72,7 +72,7 @@ views_ui.duplicate: requirements: _entity_access: view.duplicate -views_ui.delete: +entity.view.delete_form: path: '/admin/structure/views/view/{view}/delete' defaults: _entity_form: 'view.delete' @@ -87,7 +87,7 @@ views_ui.autocomplete: requirements: _permission: 'administer views' -views_ui.edit: +entity.view.edit_form: path: '/admin/structure/views/view/{view}' options: parameters: @@ -99,7 +99,7 @@ views_ui.edit: requirements: _entity_access: view.update -views_ui.edit_display: +entity.view.edit_display_form: path: '/admin/structure/views/view/{view}/edit/{display_id}' options: parameters: @@ -112,7 +112,7 @@ views_ui.edit_display: requirements: _entity_access: view.update -views_ui.preview: +entity.view.preview_form: path: '/admin/structure/views/view/{view}/preview/{display_id}' options: parameters: @@ -125,7 +125,7 @@ views_ui.preview: requirements: _permission: 'administer views' -views_ui.break_lock: +entity.view.break_lock_form: path: '/admin/structure/views/view/{view}/break-lock' defaults: _entity_form: 'view.break_lock'