diff --git a/modules/image/image.module b/modules/image/image.module index fe3cfcdf1ab5305cf685248cc59c4b1729a5c54f..5946e61073bc69de6e3845ff7f52ad8728982506 100644 --- a/modules/image/image.module +++ b/modules/image/image.module @@ -1054,7 +1054,7 @@ function image_effect_definitions() { $effects = &drupal_static(__FUNCTION__); if (!isset($effects)) { - if ($cache = cache_get("image_effects:$langcode") && !empty($cache->data)) { + if ($cache = cache_get("image_effects:$langcode")) { $effects = $cache->data; } else { diff --git a/modules/image/image.test b/modules/image/image.test index 75e96074cbc6cfe11f9ec72c2587a21d0030102d..6a5d20f20768da0dba935db31a39b2d8b82848d0 100644 --- a/modules/image/image.test +++ b/modules/image/image.test @@ -255,7 +255,7 @@ class ImageEffectsUnitTest extends ImageToolkitTestCase { } function setUp() { - parent::setUp('image_test'); + parent::setUp('image_module_test'); module_load_include('inc', 'image', 'image.effects'); } @@ -342,6 +342,25 @@ class ImageEffectsUnitTest extends ImageToolkitTestCase { $this->assertEqual($calls['rotate'][0][1], 90, t('Degrees were passed correctly')); $this->assertEqual($calls['rotate'][0][2], 0xffffff, t('Background color was passed correctly')); } + + /** + * Test image effect caching. + */ + function testImageEffectsCaching() { + $image_effect_definitions_called = &drupal_static('image_module_test_image_effect_info_alter'); + + // First call should grab a fresh copy of the data. + $effects = image_effect_definitions(); + $this->assertTrue($image_effect_definitions_called === 1, 'image_effect_definitions() generated data.'); + + // Second call should come from cache. + drupal_static_reset('image_effect_definitions'); + drupal_static_reset('image_module_test_image_effect_info_alter'); + $cached_effects = image_effect_definitions(); + $this->assertTrue(is_null($image_effect_definitions_called), 'image_effect_definitions() returned data from cache.'); + + $this->assertTrue($effects == $cached_effects, 'Cached effects are the same as generated effects.'); + } } /** diff --git a/modules/image/tests/image_module_test.module b/modules/image/tests/image_module_test.module index 0d398ab308a9022172e5136fc354f06270c5482e..8a322fb97de384574d6ae8bd5e2880dec5473c53 100644 --- a/modules/image/tests/image_module_test.module +++ b/modules/image/tests/image_module_test.module @@ -38,3 +38,13 @@ function image_module_test_image_effect_info() { function image_module_test_null_effect(array &$image, array $data) { return TRUE; } + +/** + * Implements hook_image_effect_info_alter(). + * + * Used to keep a count of cache misses in image_effect_definitions(). + */ +function image_module_test_image_effect_info_alter(&$effects) { + $image_effects_definition_called = &drupal_static(__FUNCTION__, 0); + $image_effects_definition_called++; +} diff --git a/modules/simpletest/tests/image.test b/modules/simpletest/tests/image.test index 962aa661fe9a6b06ed52dd4676497f45b1b30e53..403c9d7d88f41cb9818e1e6923dcd9073718944f 100644 --- a/modules/simpletest/tests/image.test +++ b/modules/simpletest/tests/image.test @@ -14,7 +14,13 @@ class ImageToolkitTestCase extends DrupalWebTestCase { protected $image; function setUp() { - parent::setUp('image_test'); + $modules = func_get_args(); + if (isset($modules[0]) && is_array($modules[0])) { + $modules = $modules[0]; + } + $modules[] = 'image_test'; + + parent::setUp($modules); // Use the image_test.module's test toolkit. $this->toolkit = 'test';