Fixed jeroen.theme.

1. comment() function only gets 2 arguments. And as I made example.theme from jeroen.theme I don't see how thread got in there.

2. That must have sneaked in while I stripped down my theme to get to example.theme.

3. Fixed, it was already done in my top-right navigation box, but I must've forgotten it at the bottom.

4. OK, no more variable timestamp but straigt in the code. :)

Jeroen.

During my nigthly session I fixed a few glitches in the example theme.
Read them carefully because the other theme might need updating too (I
don't think so though).  I could only commit it now because I didn't
had the time to write up these comments/remarks yet.  So here goes:

1. the comment() function only takes 2 arguments - $thread is no longer
   needed and shouldn't be used in the code either.

2. I added 2 COLSPAN's to fix a <TD> problem in the story() function.

3. <A HREF="">home</A> is will not work properly when using drupal in
   a subdirectory!  Simply use <A HREF="index.php">home</A> instead -
   it does matters. ;-)

4. Removed the $timestamp = format_timestamp(...)'s and used them
   "directly" just like this is done for format_username and others.
   It's generally more consistent now. :-)

did some stupid things in my previous update. But now it's OK (I did </BR> instead of <BR>.

Jeroen.

OK, this is perfectionism. I had http://jeroen.drop.org/ validated once again, and noticed an error with a </P>, it said that the paragraph wasn't opened. But it occured near a story as we do <P> check_output(story->abstract) </P> I was pretty certain the paragraph was open. :) OK, so it wasn't the theme's fault, neither was it the engine. Then I went to take a look at the actual story and what did I see. It used a BLOCKQUOTE. After deleting the BLOCKQUOTE, messing around with the HTML, trying to insert it again. It always gave me the error when it was inserted... What's my conclusion? BLOCKQUOTE isn't allowed inside a paragraph...
Solution? We could take the option to use the blockquote HTML tag in a story or comment out of drupal. But I really like blockquote. So I now changed <P> check_output(story->abstract) </P> to <BR> check_output(story->abstract) </BR> because, basicly, that does the same thing. I'd advise you to do so too, I might do it for you if you please. Not that I really care about it, but lately we've got some queer w3-lovers on our back. Let's shake them off, allright? ;)

Jeroen.

If we're lucky this tiny jeroen.theme update might just save us from 5 HTML 4.01 bugs.
If we're very lucky it'll solve 7.
If we're unlucky only the code has improved.

Jeroen.

OK and this should be marvin.theme. We gained like 20 lines or so. But there aren't many graphics in marvin and a lot of stuff I'd put on several lines, Dries doesn't. Nevertheless, a good optimalization. Glad Dries came up with this. :)

Jeroen.

OK I fixed UnConeD's theme. Let's hope I didn't break anything. It were 256 lines and now there are 227 left. A save of 30 lines. Not too bad huh?
Let me check Dries' theme now.

Jeroen.

OK, lets hope this works... I should've added a directory example/ in themes/ and in example/ there should be example.theme

Jeroen.

Tidyed up the code a bit, so it'd generate less errors when running it throught w3's HTML validator. Couldn't check it because I don't have any working webspace, so Dries, upload it and I'll check, I am pretty certain that it'll solve a whole lot of errors, since I fixed a bug in story... story being generated about ten times in the HTML code on drop's main page. I expect about 30 errors less...

Jeroen.

P.S.: I don't think I'll get unconed.theme and marvin.theme updated today. But I promise I'll do it tomorrow. Had to go eat with my family, just got back and in 2 hours I am leavin for the movies. Hope you don't mind, but it's always cooler to commit patches closer to the release date... gives you this "rush" feeling. Ahh, deliberately doing stuff on  the nick of time... sweet :)

- applied David Norman's patch to turn all <?'s into fully qualified
  <?php's.

I think you all read the mail about what has changed, I also did the tiny abstract/Editor's note update. :)

Jeroen.

- some important changes to our theme API which can be summerized as:

     abstract() + article() = story()

  abstract() and article() have been merged into a new function story()
  which looks like:

  function story($story_object, $reply) {
    if (!reply) {
       // full story
    }
    else {
       // main page version / abstract
    }
  }

  This should allow you to "compress" your theme as abstract() and
  article() tended to be 98% identical.

  => I didn't really merge your themes so I leave it up to *you* to
     improved the code!!! Do it ASAP as we release drupal 2.00 in 7
     days.

  In future we'll have similar functions for other content types as
  for example:

     review($review, $reply);
     enquete($enquete, $reply);
     ...

Oh, yes, I remember, I took away the drop META tags as Dries requested, also I changed the ALT="drop.org logo" to ALT="". But Dries, I can't make everything drop independant. Since I work with the random logo's...
Also removed a style tag that I didn't use.

Jeroen.

Has he gone insane! No. I just (but that's just my opinion) made a major improvement to my theme. In one of my unentertained moments I often just browse to drop and stare at my theme for a while. ;) Then I saw that the border around my boxes was 2 pixels wide and grey. Cool. But I thought, let's try it the same way as I do the stories. With a slick 1 pixel wide black border. And so I did. And I admit, it just looks a whole lot better, slicker, smoother, professional. You probably won't notice it at all, and probably no-one would notice. But again, I'd advise you to take a look at http://jeroen.drop.org and look at the boxes before Dries updates these .gifs. Another thing, Unconed, you probably know more or this. What do you think I should use for my images? .gif or .png. What's the advantage of .png, and most of all, is it smaller in size?

Jeroen.

P.S.: another jeroen.theme is coming up. Don't even know what I changed anymore but I changed something...

I updated some things, remove some PHP lines in the comment function, that I think weren't necessary (did that in the previous commit but forgot to mention it) also I renamed all the PHP?> tags to ?>. I read in the docs at http://php.net that this is the way to go. Also I renamed all <? to <?PHP. I added a BCGOLOR again, so my theme's build up is a little nicer again. Spotted four (yes 4) bugs. I now use regular HTML to assign colors but in abstract and article, the sections were still done the old way. Fixed that now, but left them black. Oh yeah, I fixed that weird rendering of my theme I think Dries was talking about. He didn't exactly mention what was wrong but I assume that it were the links in abstract and article that didn't display at the right of the story. Because I deleted some tables I had to add COLSPAN="2". However, when I loaded my page locally on eden it displayed correct. But when I browsed to drop it didn't (in the same browser) Do you get it? I sure don't. It was the same HTML code, but seems differently parsed when coming from an outside server. Allthough I don't see why Netscape would see apache locally as something different than another one. Nevertheless, I think it's fixed.

Jeroen.

I tweaked my theme a bit, don't know if it'll help much but I was able to squeeze a table out of abstract and article. So what you'd say? Well, since the abstract function is called for every post on the main page, I thought that it'd improve it a bit. Of course it isn't much but less tables to show the same is always a good thing. Also, due of the deleted table, I could delete some backgrounds (less traffic from the server to the client) and placed them once in a TABLE header. OK, but a cool side-effect is that it's more HTML 4.01 compliant. Because BACKGROUNDs are allowed in TABLEs and I think it's a bit unclear if they can be in TD yes or no. Either way, this brought to my attention that my !DOCTYPE is strict... I started of strict though... But I think it's a better idea to switch to transitional/loose. OK I think that was it... Oh also because of the changed TABLE structure I had to delete some BGCOLORs. Again, it might be a teeny weeny bit faster, but when you see my site being build up it isn't that nice anymore. (bgcolors are displayed faster than backgrounds). Nevertheless its the result that counts not? Let's hope everything still works.

Jeroen.

- various smaller updates before I start watching Formula 1 with [a] a
  0.5 liter box of Haagen-Dhaz (Belgian Choclate) and [b] my laptop on
  my lap for drupal hacking.  Life hardly can get any better than this.

code revision:
  - small "path"-fix with logo which could have triggered when running
    drupal in a subdirectory

- As I'm working down my TODO list, I updated your themes:

    $theme->comment() only takes 2 parameters ever since the comment
    system rewrite 2 months ago. Make sure to update your local tree
    before you start hacking away on your themes.

- removed all hardcoded references to "drop.org" from my theme

- forgot to wrap the links in the footer and header in t()-functions
  (Is your theme 100% translatable or not?)

- fixed small translation glitch in format_interval
- added a couple of missing t() functions
- improved the comments module, fixed the score problem Jeroen
  reported earlier -> it's slicker but I hope it won't break anything

Should be OK now, also put a TD and a TR on seperate lines somewhere... seems to fix a little graphical glitch I somethimes have, but I could've just been lucky too when I reloaded last times. :)

Jeroen.

Another jeroen.theme commit is coming up since I made some changes to test the gif I changed and didn't undo them.

Jeroen.

It looks like the subject in the comments still don't show, this is because i did $comment->$subject instead of $comment->subject
Ai ai.

Jeroen.

I say Unconed's little drops and said: "Damn, how come that he, with so few pixels can create something that smooth...". That's why I went down in my .gif archive and smoothed the drop in  footerleft.gif, (the pipe with the open end in which you see a drop). It looks better now, maybe you won't see it but I do. :) I have drawn every gif pixelbased and that's why it's difficult to smoothen edges and stuff. I can't work well with the gimp and if you want certain cool effects you have to know how. Since creating a cool effect with the gimp takes like 15 weird tricks and layershuffles and filters and merges and keep transparancies and you don't get any result before you do that final step which suddenly gives you this wonderful thing. I think it's just too hard for me...
Nevertheless, here's the new footerleft.gif, you might want to check out htpp://jeroen.drop.org before Dries loads it up, otherwise you'll probably think I'm crazy :)

Jeroen.

Fixed a small bug, there was a ';' too much in a echo "" which would just be printed like normal HTML text in the abstracts' and articles' headers...

Jeroen.

Updated the stupid fonts issue (the conclusion was to use *EVEN* font sizes and not uneven as Dries recommended... bah! :)

I also added a small icon (like marvin.theme) to spice it up a bit.

Removed useless images (that stupid theme.gif that looked cool, but was unimplementable in NS) and added a cool icon.gif

OK I wrote a lengthy text with my previous commit, but due to an Up-to-date check failure it got aborted. So here it is in short. I added the translation functionality and fixed a bug that would cause the comment's subjects not to display. Apparantly it's comment->subject instead of just subject. I also wanted to make something in the comment header a bit more clear I already changed some colors but I would want the comment's rating/score to display black. It's grey now and on a grey background it isn't so clear to read (lisible in decent english?). So I added something that I thought would paint it black, but obviously it didn't. It's still grey. I didn't remove the code, it's only two lines, because it also works this way. For the rest I don't think that anything changed.

Jeroen.

P.S.: Dries, I think we can release it tomorrow, but wait and upload it to http://jeroen.drop.org first so I can check. And at noon we'll let it out. It's yearning to, I can here it growl and make roaring noises in my laptop...

- removed the "colour sets" from my theme: the color variables (except for
  $link) are no longer needed by the engine so I decided to tidy them up -
  I recommand you to do same if you feel like it (and if you haven't
  already done so).

- fixed bug in block placement when (1) using a theme with 2 side bars
  and (2) being logged out.
  (reported by Jeroen)
- themed "Editor's note" in theme marvin.
  (reported by Jeroen)

OK, now it's finished, really. Fixed a small gfx glitch, and the categories seem to be called sections now...

It's done, and ready for release. Really.

Jeroen.

I placed all the blocks left, regardless if their region was left or right, what I did was this:
theme_blocks("all", $this);
in my left <TD>.

Now I changed it to
theme_block("left", $this);
in the left <TD> and
theme_blocks("right", $this);
in the right. If everything was this easy.

OK, really, this theme is NS4.7 NS4.76 mozilla (but mozilla 0.8 cuz he's buggy as hell with the BACKGROUNDS in TDs) and IE comliant or compatible, whatever it's being called.

Jeroen. -- Happy.

Jeroen.

- improved comment module - code revision
- improved backend module - moreover headlines now work
- (automatically) stripped tabs and trailing whitespaces from
  Jeroen's theme.

This solves the _my_footer_pipe_was_one_pixel_too_low_ problem. It should display OK now. For the weird upper-right navigation box Dries, I really wouldn't know what goes wrong. I don't have the problem. Haven't changed a thing on the boxes, My winme's IE doesn't have the problem... Maybe netscape 4.7 just displayed it wrong only once. Try it again, and if it keeps going wrong. I'll download NS 4.7 and will try to fix it. (That'll be my fourth browser then)

Jeroen.

P.S.: I think my theme is completed... Of course the code might need some cleaning up but I think it is ready to be used by droppies without giving away the code. That'll be in the next drupal release.

Deleting redundant .gifs since now I work with that table in table thing to create borders around boxes. Nothing has changed with newsmiddle.gif so don't expect the backgrounds behind the stories' titles to differ.

Jeroen.

Small bug fixes, added some NOWRAPs and other stuff. This is also an attempt to fix the widths of the boxes on the sides... I don't know if it'll work, and frankly I doubt if it would... Let me elaborate... You know that I have three colums, one for the left boxes, the middle for the stories and one for the right boxes... I didn't provide a width for any of these <TD>s. That's why it chose it's width randomly. Then I set them to these values, respectively 20 60 and 20%. That went OK, but another problem occurred. We only have boxes on the main page. And on the other pages. e.g. faq, submit news, search... we only have the <user>'s account box on the right. This results in a large white border on the left (lost space). That's why I did the following... but I am afraid it won't work... I set the widths to: <no width> 100% 20% So, now, when we have boxes on the left it'll display them, when there aren't any, the middle <TD> will take up the rest op the space, being 100%, it worked fine on my computer with my browsers... But since I use the kind of browser no-one else uses (linux mozilla 0.8 which sucks and linux NS6.01) it is no reference. I would want to stress again that my theme isn't mozilla compatible or how do you say that, in fact it'd better be mozilla isn't jeroen.theme compatible, it's buggy as hell with the backrounds. OK enough for now, let's see if anything good happens to my theme.
Dries, be so kind to get my jeroen.theme working at http://jeroen.drop.org.

Jeroen.