Skip to content
  1. Feb 08, 2005
  2. Jan 26, 2005
  3. Jan 25, 2005
  4. Dec 07, 2004
    • Dries Buytaert's avatar
      · 60352821
      Dries Buytaert authored
      - Refactored the queue module: removed the queue module's field from the node table.  With help from Gerhard.
      
      - Slight addition to INSTALL.txt with regard to PHP versions.
      
      - Updated/reworded some node type descriptions as per Boris' suggestions.
      
      - Adding missing {} around a table name in update.php.
      60352821
  5. Oct 23, 2004
  6. Sep 29, 2004
    • Dries Buytaert's avatar
      · 98b11655
      Dries Buytaert authored
      - Removed the link feature.  It was death code, bound to confuse people.
      
        TODO after Drupal 4.5.0: clean up the page module and remove additional cruft.
      98b11655
  7. Sep 28, 2004
  8. Sep 16, 2004
    • Dries Buytaert's avatar
      · 5c7983c4
      Dries Buytaert authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  9. Aug 21, 2004
    • Dries Buytaert's avatar
      · 94e30bf7
      Dries Buytaert authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  10. Aug 10, 2004
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  11. Jul 31, 2004
  12. Jul 30, 2004
    • Dries Buytaert's avatar
      · aed1b0ca
      Dries Buytaert authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  13. Jul 13, 2004
    • Dries Buytaert's avatar
      · 1c52b145
      Dries Buytaert authored
      - Patch #8080 by TDobes: added teaser support to the book and page module.
      1c52b145
    • Dries Buytaert's avatar
      · 3613729d
      Dries Buytaert authored
      - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents.  In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
      
      Changes are as follows:
      "maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
      "maintain personal pages" -> "edit own pages" (page.module)
      "maintain personal stories" -> "edit own stories (story.module)
      3613729d
  14. Jul 08, 2004
    • Dries Buytaert's avatar
      · 898bdeff
      Dries Buytaert authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  15. Jul 07, 2004
  16. Jul 04, 2004
    • Dries Buytaert's avatar
      · fe2b3e7c
      Dries Buytaert authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  17. Jun 18, 2004
    • Dries Buytaert's avatar
      · 54b77d64
      Dries Buytaert authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  18. May 09, 2004
  19. Apr 21, 2004
    • Dries Buytaert's avatar
      · 7231c88a
      Dries Buytaert authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  20. Mar 10, 2004
  21. Feb 10, 2004
    • Dries Buytaert's avatar
      · 254ca4b9
      Dries Buytaert authored
      - Patch 5729 by Goba: removed dead code from page.module.
      254ca4b9
  22. Jan 31, 2004
    • Dries Buytaert's avatar
      · 48a4dff8
      Dries Buytaert authored
      - Patch by Goba: added form descriptions where appropriate and removed some
        duplicated code from the comment module.
      48a4dff8
  23. Jan 27, 2004
    • Dries Buytaert's avatar
      · 1687dd07
      Dries Buytaert authored
      - Patch 5049 by JonBob: allow a module to define multiple node types.
      1687dd07
  24. Jan 23, 2004
    • Dries Buytaert's avatar
      · b85eb11e
      Dries Buytaert authored
      Patch 5287 by Stefan: multiline help texts should become inside a single $output.
      b85eb11e
  25. Jan 17, 2004
    • Dries Buytaert's avatar
      · 860a5cc3
      Dries Buytaert authored
      - Removed the $help parameter from the _form hook.  The help, typically
        submission guidelines, should be emmitted using the _help hook.
      860a5cc3
  26. Jan 11, 2004
    • Dries Buytaert's avatar
      · 5ac59aac
      Dries Buytaert authored
      - Applied patch #4949: node_prepare() wastes resources.  Patch by Goba.
      5ac59aac
  27. Jan 02, 2004
    • Dries Buytaert's avatar
      · a9ef1826
      Dries Buytaert authored
      - Patch 4916: improved preparation of $node->teaser and $node->body.  Patch by
        Goba.
      a9ef1826
  28. Nov 25, 2003
    • Dries Buytaert's avatar
      · c0494c0a
      Dries Buytaert authored
      - Committed phase 4 of JonBob's menu system changes.
      c0494c0a
  29. Nov 20, 2003
    • Dries Buytaert's avatar
      · 4bdac433
      Dries Buytaert authored
      - Patch by JonBob:
      
        Phase 2 of the menu system integration project. This unifies the interface
        used by admin and non-admin pages, and deprecates the _page hook in favor of
        explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
        as a result of this patch; they will return in the phase 3 patch, printed
        by the theme.
      4bdac433
  30. Nov 09, 2003
    • Dries Buytaert's avatar
      · 951b553a
      Dries Buytaert authored
      - Committed stage 2 of the theme system improvements!  Patch by CodeMonkeyX.
      951b553a
  31. Nov 08, 2003
    • Dries Buytaert's avatar
      · 92995414
      Dries Buytaert authored
      - Committed stage 1 of the menu callbacks improvements.  Patch by Jonathan.
      92995414
  32. Nov 07, 2003
    • Dries Buytaert's avatar
      · ef0fa006
      Dries Buytaert authored
      - Usability improvement: replaced many selection boxes by radio buttons.
        Patch by Stefan.
      ef0fa006
  33. Oct 09, 2003
    • Dries Buytaert's avatar
      · 1a5fcacd
      Dries Buytaert authored
      - Committed part 3 of Michael's help system improvements: removed the $help
        parameter from the menu() function.
      1a5fcacd
  34. Oct 07, 2003
    • Dries Buytaert's avatar
      · 22c889e7
      Dries Buytaert authored
      - Help system improvements: eliminated the _system hook.  Patch by Michael.
      
      - Bloggerapi module fixes.  Patch by Kjartan.
      
      - Coding style fixes.  Patch by Michael.
      22c889e7
  35. Oct 03, 2003
    • Dries Buytaert's avatar
      · 058971c3
      Dries Buytaert authored
      - Help improvements and translation improvements from Michael.  Thanks!
      058971c3
  36. Sep 30, 2003
    • Dries Buytaert's avatar
      · 5a667eb5
      Dries Buytaert authored
      - Url aliasing improvements.  Patch by Matt.  See mailing list for more
        information.
      5a667eb5
  37. Sep 28, 2003
    • Dries Buytaert's avatar
      · 32e8d77c
      Dries Buytaert authored
      - Associate a callback with the menu links!  (This callback is not yet being
        called but will be as soon the remaining links have been transformed to use
        the menu system.)
      
      - Made sure the menu does not render links with no callback and no children.
        Like this, the 'create content' link is not being shown when the user has
        no permission to add any content.
      32e8d77c
  38. Sep 27, 2003
    • Dries Buytaert's avatar
      · fe09d5a7
      Dries Buytaert authored
      - Committed Al's new admin link texts.  Remarks:
      
        1) As explained by Al, there is still a glitch with the 'create content'
           menu.
        2) The user module part of the patch did not apply due to Kjartan's earlier
           patch.
      fe09d5a7