Skip to content
  1. Aug 14, 2005
  2. Jul 29, 2005
  3. Jul 25, 2005
  4. May 31, 2005
  5. Apr 12, 2005
  6. Feb 12, 2005
  7. Jan 29, 2005
  8. Jan 26, 2005
  9. Jan 25, 2005
  10. Jan 16, 2005
    • Dries Buytaert's avatar
      · 971a0e24
      Dries Buytaert authored
      - Patch #14731 by chx: made it possible to rewrite node queries.
      971a0e24
  11. Dec 15, 2004
    • Dries Buytaert's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries Buytaert authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  12. Dec 07, 2004
    • Dries Buytaert's avatar
      · 60352821
      Dries Buytaert authored
      - Refactored the queue module: removed the queue module's field from the node table.  With help from Gerhard.
      
      - Slight addition to INSTALL.txt with regard to PHP versions.
      
      - Updated/reworded some node type descriptions as per Boris' suggestions.
      
      - Adding missing {} around a table name in update.php.
      60352821
  13. Nov 24, 2004
    • Dries Buytaert's avatar
      · 4726c931
      Dries Buytaert authored
      - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated.  Check your contributed modules and update them accordingly.
      4726c931
    • Dries Buytaert's avatar
      - Patch #10990 by TDobes: adds a "create new blog entry" link at the top of... · 062a8abd
      Dries Buytaert authored
      - Patch #10990 by TDobes: adds a "create new blog entry" link at the top of each user's own blog page, similar to the "post new forum topic" link displayed at the top of forum pages. This adds consistency as well as convenience for users.
      062a8abd
  14. Nov 23, 2004
  15. Oct 31, 2004
    • Dries Buytaert's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries Buytaert authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
  16. Oct 23, 2004
  17. Oct 09, 2004
  18. Sep 28, 2004
  19. Sep 27, 2004
    • Dries Buytaert's avatar
      - Patch #11045 by Stefan: improved consistency of node modules: · ff17aa0b
      Dries Buytaert authored
        + made the helptext under the 'Explanation or submission guidelines', more the same (blog & story);
        + made the form_set_error() texts consistent when the body of a blog/story does not match or exceeds the specified minimal numer of words.
        + used the $options for form_select() and form_radios() inline like we do in the rest of drupal;
        + made the textarea sizes for the submission pages the same for all node types and also for the 'Explanation or submission guidelines';
      ff17aa0b
  20. Sep 21, 2004
  21. Sep 16, 2004
    • Dries Buytaert's avatar
      · 5c7983c4
      Dries Buytaert authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  22. Sep 14, 2004
  23. Sep 08, 2004
    • Dries Buytaert's avatar
      · 7b716e8e
      Dries Buytaert authored
      - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
      
        1) Menu problems with Postgres (this is a highly critical 1 line fix)
        2) Archive module fails with Postgres
        3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
        4) Book module fails with Postgres
        5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
        6) Creating accregator_item_table in PostgreSQL
        7) Postgres - Polls not displayed on Poll Page
        8) Blog module has sql errors with postgres
      
        This should not affect MySQL users (hopefully).
      7b716e8e
  24. Aug 21, 2004
  25. Aug 12, 2004
    • Dries Buytaert's avatar
      · 0f088b79
      Dries Buytaert authored
      - Patch #9983 by Stefan: various code style improvements.
      0f088b79
  26. Aug 10, 2004
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  27. Jul 31, 2004
    • Dries Buytaert's avatar
      · 202eee42
      Dries Buytaert authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  28. Jul 30, 2004
    • Dries Buytaert's avatar
      · aed1b0ca
      Dries Buytaert authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  29. Jul 25, 2004
    • Dries Buytaert's avatar
      · 702a0576
      Dries Buytaert authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
      
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
      
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
      702a0576
  30. Jul 16, 2004
    • Dries Buytaert's avatar
      · 2a538a39
      Dries Buytaert authored
      - Patch by Andy: improved help text / module description.
      2a538a39
  31. Jul 13, 2004
    • Dries Buytaert's avatar
      · 3613729d
      Dries Buytaert authored
      - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents.  In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
      
      Changes are as follows:
      "maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
      "maintain personal pages" -> "edit own pages" (page.module)
      "maintain personal stories" -> "edit own stories (story.module)
      3613729d
  32. Jul 08, 2004
    • Dries Buytaert's avatar
      · 4dbc900d
      Dries Buytaert authored
      - Renamed the blog module's block for sake of clarity.
      
      - Made the blog module's submission form mark required form fields.
      4dbc900d
  33. Jul 04, 2004
    • Dries Buytaert's avatar
      · fe2b3e7c
      Dries Buytaert authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
    • Dries Buytaert's avatar
      · 353c05d0
      Dries Buytaert authored
      - Made it possible to edit blog posts and made the blog module use tabs.
      353c05d0
  34. Jun 30, 2004
  35. Jun 27, 2004
    • Dries Buytaert's avatar
      · 0a352809
      Dries Buytaert authored
      - Patch #8603 by TDobes: added support for sticky forum topics to the blog
        and forum module.
      0a352809