create branch 'DRUPAL-4-4'.

Cherrypick from master 2004-04-12 09:52:30 UTC Dries Buytaert <dries@buytaert.net> '- Added forum-closed.gif created by kika.':
    misc/forum-closed.gif

* Code cleaning: simpler structures, removed some old leftovers, ...
* Clean URLs everywhere (the old mechanism was broken anyway). Had to get rid of 'inline voting' (i.e. voting with the sideblock and ending up on the same page), but that was a bit confusing anyway.
* Simplified submission form with form_group and streamlined choice mechanism.
* Improved bar rendering in pollresults for themes with avatars, like xtemplate.

Improved <label> patch: got rid of ID's by implicit association, and made radio/check labels non-bold again.

- Patch #5569 by mathias: fixed jumpy menu behavior with konqueror.

- Small CSS improvements to help fix bug 5145.

- Usability improvement: added a book navigation block.

- Bugfix: fixed incorrect placement of book module navigation.
- Made some of the menu styles reusable by other lists.

Round 3 of aggregator improvements:

 - Added support for new tags:
   + Optinal feed image: <image> tag.
   + Dublin core dates: <dc:date> <dcterms:created>, <dcterms:issued>,
     <dcterms:modified>.
 - Usability improvements:
   + On the administration page, made the feed/bundle titles link
     to the feeds/bundles' pages.  On the feed/bundle's page, made
     the 'Last updated' field link to the administration page.
   + Moved the 'syndication' menu one level down.
 - Updated some content sensitive help.
 - Further improved themeability.
 - Fixed some invalid HTML.

 + Added some a new theme fucntions to the aggregator to make it possible to
   theme the aggregator page.
 + Removed the <table> and much hardcoded CSS as well as theme("box")-es.
 + Added the aggregator's theme functions to Doxygen's themeable group.
 + Added breadcrumb trails to the aggregator pages.
 + Updated the core themes to take advantages of the improved themeability.

Screenshot:

 http://buytaert.net/temporary/aggregator-makeover.jpg

- Fixed bug #4922: made misc/drupal.css validate by removing some Mozilla
  specific code.

- Removed some dead code from drupal.css.

- Removed some dead CSS code.

- Improvement: made it so that by default, images have no borders.

- Moved to grey arrow buttons instead of orange ones.  Updates by Kristjan.

- CSS improvements by Kristjan: <hr />-tag styling, better fieldset and table row
  padding, more subtle color to watchdog special messages.

- Small improvement to the watchdog table.

- Patch 0178 by eafarris: moved the watchdog colors to CSS so they are themeable.

- Introduced a drupal_set_message() and drupal_get_message() function.

  Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.

- Fixed positioning of fieldset elements in IE.

- Improved module loading when serving cached pages.  Moshe's bootstrap patch.

- Used legend and fieldset tags for the configuration page.

- Improved form items: added <label> tags to improve accessibility and added
  theme_form_element() function to improve themeability.  I left form_item()
  and the calls to form_item() intact for now.

- Avoid fieldsets being rendered one below another.  Patch by Ax.

- Bugfix: changed id="menu" to class="menu" to avoid id="menu" being emitted
  twice.  Patch by Jim Riggs.

- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.

  "create content" link.

- Manually merged the user module's new menu items.  Al's patch did not
  apply.

- Added some missing t()s.

   + Fixed CSS to use the same format as the rest of drupal.css.
   + Added fallback routine for menu icons.
   + Fixed anonymous users not seeing the menu.
   + Added proper access checks for admin and help menu items.

- Committed the admin menu integration patch.  Thanks Adrian, Stefan and others.

- Added $Id$ tags.  Patch by Chris.

- Book module improvements.  This commit changes the behavior of the "view"
  hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.

- Made sure the 'Topic' title is only shown above the topics, not the icons.

- Automatically shorten the username when it is too long.  I implemented this
  as part of format_name() and could therefore nuke some code in the
  statistics module.  This is change is somewhat experimental and I'm willing
  to revert or change this if a number of people aren't too happy with this
  behavior.

- Left align the dates and authors: makes it easier/faster to scan.

- Made the little tablesort arrows clickable.

- Swapped the arrow images: takes care of bug #2591 reported by Al.

  PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.

- Applied Moshe's tablesort patch!  Note that I changed the arrow images
  because those of Moshe where not identical.

- Rewrote handling of forum icons and added default icons made by Steven
  Wittens.

- Renamed some column titles in the forum module as per Moshe's suggestion.

- Introduced a 'more-link' class to position the 'more' links.  Removed
  hard-coded markup from the modules.

- Fixed bug in import module: the theme functions called a non-existing
  function.

1) Bugfix: changed INNER JOIN to LEFT JOIN to make forum topics with no comments show on the topic overview page.

2) Beautified the forum module views; rewritten to use the table() rendering functions, X HTML-ified the emitted code, added additional CSS tags, and removed hard-coded markup.  This improves themeabality; it should be able to mimic the view and color scheme of, say, http://www.phpbb.com/.

3) Reorganized forms and links (interactive elements) to improve usability.  Also ensured that the link names and page titles match.

4) Temporary removed container functionality: this simplified the work and eliminated some usability issues.

- Fix link_page to use l() to generate home link.

Applied 0058.kika.themeable-usermenu.patch
- Modifies user menu be themeable.