- Feb 25, 2011
-
-
The Great Git Migration authored
-
- Nov 15, 2006
-
-
Gerhard Killesreiter authored
#76819, node_db_rewrite_sql breaks modules when node_access and PostgreSQL are used, backport from HEAD, patch by sammys
-
- Oct 12, 2006
-
-
Gerhard Killesreiter authored
-
- Sep 26, 2006
-
-
Gerhard Killesreiter authored
-
- May 24, 2006
-
-
Gerhard Killesreiter authored
-
- Apr 27, 2006
-
-
Steven Wittens authored
-
- Apr 11, 2006
-
-
Gerhard Killesreiter authored
-
- Feb 26, 2006
-
-
Dries Buytaert authored
-
- Feb 20, 2006
-
-
Dries Buytaert authored
-
- Jan 24, 2006
-
-
Dries Buytaert authored
-
- Jan 21, 2006
-
-
Steven Wittens authored
- #40515: Ensure UTF-8 character set on the database side (and include upgrade path for incorrectly set up databases)
-
- Dec 07, 2005
-
-
Dries Buytaert authored
- Patch #38889 by rkerr: db_error and db_affected_rows did not work properly in presence of multiple database connections.
-
- Dec 06, 2005
-
-
Dries Buytaert authored
-
- Nov 29, 2005
-
-
Dries Buytaert authored
-
- Nov 27, 2005
-
-
Dries Buytaert authored
-
- Nov 21, 2005
-
-
Steven Wittens authored
#36658: Make search query pgsql compatible.
-
- Nov 04, 2005
-
-
Steven Wittens authored
- Prefix temporary table names (helps on restricted hosts)
-
- Oct 20, 2005
-
-
Steven Wittens authored
- Add maintenance-page error screens when the php module for the dbtype is not loaded (just showed a blank screen before)
-
- Oct 18, 2005
-
-
Steven Wittens authored
Presentation about it: http://www.acko.net/files/drupal-search-slim.pdf
-
- Aug 29, 2005
-
-
Dries Buytaert authored
use db_lock_table() and db_unlock_tables() for your code to be compatible.
-
- Aug 25, 2005
-
-
Dries Buytaert authored
-
- Aug 11, 2005
-
-
Dries Buytaert authored
- Patch #25522 by Cvbge: _db_query() does not return FALSE in case of errors as stated in documentation.
-
- Jul 30, 2005
-
-
Steven Wittens authored
-
- Jul 27, 2005
-
-
Steven Wittens authored
-
- Jun 22, 2005
-
-
Dries Buytaert authored
up the documentation a little. chx: can you double-check whether the global $conf variable is secure? (That is, make sure it can't be send using the URL or something.)
-
- May 23, 2005
-
-
Dries Buytaert authored
-
- Apr 08, 2005
-
-
Dries Buytaert authored
-
- Jan 07, 2005
-
-
Dries Buytaert authored
-
- Nov 29, 2004
-
-
Dries Buytaert authored
- Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent: db_query($query, $a, $b, $c); db_query($query, array($a, $b, $c)); This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places. However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call. This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions. I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc. Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example: - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3"); - $params[] = 0; - $params[] = 1; - $result = call_user_func_array('db_query_range', $params); + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1); and - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit))); + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit); I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too. This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query. This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself. With the new, documented syntax, there is no more excuse to put data directly in the query.
-
- Nov 21, 2004
-
-
Dries Buytaert authored
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend. Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
-
- Sep 20, 2004
-
-
Dries Buytaert authored
- Patch #10945 by Adrian: more PostgreSQL fixes/updates.
-
- Sep 09, 2004
-
-
Dries Buytaert authored
- Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
-
- Sep 08, 2004
-
-
Dries Buytaert authored
- Patch #10622 by Adrian: fixes various PostgreSQL related problems. 1) Menu problems with Postgres (this is a highly critical 1 line fix) 2) Archive module fails with Postgres 3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch) 4) Book module fails with Postgres 5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug. 6) Creating accregator_item_table in PostgreSQL 7) Postgres - Polls not displayed on Poll Page 8) Blog module has sql errors with postgres This should not affect MySQL users (hopefully).
-
- Jul 14, 2004
-
-
Dries Buytaert authored
- Patch #9287 by JonBob: made the code style in the three database include files consistent with Drupal standards, and adds a wealth of Doxygen-style comments to aid developers in writing solid database access code using the API.
-
- Apr 30, 2004
-
-
Dries Buytaert authored
- Patch by Adrian: added support for multiple database connections.
-
- Dec 08, 2003
-
-
Dries Buytaert authored
- Tidied up the DoxyGen comments. Patch by Kjartan.
-
- Nov 24, 2003
-
-
Dries Buytaert authored
* fixes all doxygen warnings [#]_ in the current code base + changes @param style from phpDocumentor (@param type $var desc) to doxygen (@param $var desc) + documents all undocumented parameters + escapes / fixes html warnings + fixes @defgroup in theme.inc * adds more groupings [#]_ + drupal_{set|get}_title, drupal_{set|get}_breadcrumb + pager.inc: pager_api (pager_query(), pager_display()), pager pieces * adds a new group "themeable" which contains all themeable functions.
-
- Oct 22, 2003
-
-
Dries Buytaert authored
- Bugfix: prefix not prepended to sequences. Fixes bug #3639. Make sure to write: db_next_id({table}_field); instead of: db_next_id(table_field);
-
- Jul 21, 2003
-
-
Dries Buytaert authored
- Fixed node_save() and user_save() bug introduced by table prefix changes. Modified patches from Gerhard. - Changed the order of the checks in node_teaser(). Patch from Kobus.
-
- Jul 10, 2003
-
-
Dries Buytaert authored
- Committed a slightly modified version of Slavica's table prefix patch.
-