create branch 'DRUPAL-4-5'.

Sprout from master 2004-10-18 18:40:53 UTC Dries Buytaert <dries@buytaert.net> '- Fixed parentheses.'
Delete:
    modules/aggregator/aggregator.module
    modules/archive/archive.module
    modules/block/block.module
    modules/blog/blog.module
    modules/blogapi/blogapi.module
    modules/book/book.module
    modules/comment/comment.module
    modules/drupal/drupal.module
    modules/filter/filter.module
    modules/forum/forum.module
    modules/help/help.module
    modules/legacy/legacy.module
    modules/locale/locale.module
    modules/menu/menu.module
    modules/node/node.module
    modules/page/page.module
    modules/path/path.module
    modules/ping/ping.module
    modules/poll/poll.module
    modules/profile/profile.module
    modules/search/search.module
    modules/statistics/statistics.module
    modules/story/story.module
    modules/system/system.module
    modules/taxonomy/taxonomy.module
    modules/throttle/throttle.module
    modules/tracker/tracker.module
    modules/upload/upload.module
    modules/user/user.module
    modules/watchdog/watchdog.module

- Patch by James: made the blogapi module work again.

- Patch #11510 by Adrian: turned a non-ANSI SQL query into ANSI SQL so it works with PostgreSQL.

- Patch #11682: changed FILTER_DEFAULT_FORMAT to FILTER_FORMAT_DEFAULT to make the Blog API work.

- Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for creating/previewing new comments. The node on which your commenting and its location within the menu is not displayed. Instead, there is only a "Home" link. This is especially apparent when the "add new comment" form is set up to display on a separate page.

- Patch by Gerhard: small update to INSTALL.txt.

#11449: Adding a failsafe check for an improperly prefixed menu sequence. This is a temporary fix, awaiting a proper install system to end manual prefixing ;).

  + Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes).  The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).

  + On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.

- Patch #11642 by Steven: when editing a user as an admin, you can choose the user's roles through form checkboxes. If the form validation fails and the form is redisplayed, the roles are lost. This is because the format for $user->roles is different from what form_checkboxes uses.

- Fixed bug #9948: added some checks to system_setting_save() to avoid PHP warnings/errors.

- Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.

Tablesort used to output class=" active" for active columns with other properties (align="right"). Now it correctly uses class="foo active" if a class 'foo' was specified, and class="active" otherwise.

search: Removing iso-8859-1 characters from update_index() and adding the same stripping to do_search().
This fixes the embarrasing bug of not being able to search for "4.5.0" because it is indexed as "450".

- Patch #11605 by TDobes: if a user happens to have uid=0 defined in their database, the name assigned to that user will always override any name submitted by an anonymous commenter. Checking against $user->uid instead of $user->registered_name fixes this problem.

- Mofified patch #8862 by puregin: improved book module documentation.

- Patch #11600 by jhriggs: the module_load_all() function will currently behave unexpectedly if a module cannot be found (has been removed, renamed, etc). Once one module fails to load, all subsequent modules will not be loaded due to a short circuit condition when performing a boolean AND.

- Patch #11577 by drumm: changed t('ago') -> t('%time ago', ...) to make it
  translatable in languages such as Spanish.

- Fixed bug #11312: menu caching to aggresively.  I did not apply the proposed
  patch but moved the menu-logic to the $may_cache clause and added some checks
  to avoid SQL overhead.  I think this is the most performant solution.

- Patch #10677 by drumm: removed dead code.  Leftover.

Bug: the default filter setup had the wrong filter delta for the linebreak filter. Now it matches updates.inc.

  I rewrote this patch for simplicity.

- Patch #11530 by Frodo: fixed long filter tips.

- Patch #9292 by Gerhard: fixed another array_merge + PHP5 woe.

- Modified patch #10613 by killes: generate a 'page not found'-page when a requested node does not exist.  I modified the patch to avoid duplicate 'not found'-checking in the second bulk.