- fixed small bug in submit.php

Fixed jeroen.theme.

1. comment() function only gets 2 arguments. And as I made example.theme from jeroen.theme I don't see how thread got in there.

2. That must have sneaked in while I stripped down my theme to get to example.theme.

3. Fixed, it was already done in my top-right navigation box, but I must've forgotten it at the bottom.

4. OK, no more variable timestamp but straigt in the code. :)

Jeroen.

During my nigthly session I fixed a few glitches in the example theme.
Read them carefully because the other theme might need updating too (I
don't think so though).  I could only commit it now because I didn't
had the time to write up these comments/remarks yet.  So here goes:

1. the comment() function only takes 2 arguments - $thread is no longer
   needed and shouldn't be used in the code either.

2. I added 2 COLSPAN's to fix a <TD> problem in the story() function.

3. <A HREF="">home</A> is will not work properly when using drupal in
   a subdirectory!  Simply use <A HREF="index.php">home</A> instead -
   it does matters. ;-)

4. Removed the $timestamp = format_timestamp(...)'s and used them
   "directly" just like this is done for format_username and others.
   It's generally more consistent now. :-)

- forgot to commit this last night but this should fix deekayen's small
  Windows glitch

- fixed bug in headline module

did some stupid things in my previous update. But now it's OK (I did </BR> instead of <BR>.

Jeroen.

Ehm in affiliate-sites and dupal-site we use SCRIPT, but w3 complained about the fact that there was no TYPE attribute specified with SCRIPT, I added SCRIPT=\"\" with both tags... (I have no clue what type of script we are using but at least this fixes a bug :)) It worked here locally, let's hope it still does on the wired...

Also I corrected a </TTH> into a </TH> somewhere in the code of one of the modules, my eye just caught it, nothing special ;)

Jeroen.

OK, this is perfectionism. I had http://jeroen.drop.org/ validated once again, and noticed an error with a </P>, it said that the paragraph wasn't opened. But it occured near a story as we do <P> check_output(story->abstract) </P> I was pretty certain the paragraph was open. :) OK, so it wasn't the theme's fault, neither was it the engine. Then I went to take a look at the actual story and what did I see. It used a BLOCKQUOTE. After deleting the BLOCKQUOTE, messing around with the HTML, trying to insert it again. It always gave me the error when it was inserted... What's my conclusion? BLOCKQUOTE isn't allowed inside a paragraph...
Solution? We could take the option to use the blockquote HTML tag in a story or comment out of drupal. But I really like blockquote. So I now changed <P> check_output(story->abstract) </P> to <BR> check_output(story->abstract) </BR> because, basicly, that does the same thing. I'd advise you to do so too, I might do it for you if you please. Not that I really care about it, but lately we've got some queer w3-lovers on our back. Let's shake them off, allright? ;)

Jeroen.

If we're lucky this tiny jeroen.theme update might just save us from 5 HTML 4.01 bugs.
If we're very lucky it'll solve 7.
If we're unlucky only the code has improved.

Jeroen.

OK and this should be marvin.theme. We gained like 20 lines or so. But there aren't many graphics in marvin and a lot of stuff I'd put on several lines, Dries doesn't. Nevertheless, a good optimalization. Glad Dries came up with this. :)

Jeroen.

OK I fixed UnConeD's theme. Let's hope I didn't break anything. It were 256 lines and now there are 227 left. A save of 30 lines. Not too bad huh?
Let me check Dries' theme now.

Jeroen.

- fixed small glitch as a result from David's patch

- fixed "AdNewz.com" vs "ADNEWS.COM" glitch reported by Peter Beckman

OK, lets hope this works... I should've added a directory example/ in themes/ and in example/ there should be example.theme

Jeroen.

Tidyed up the code a bit, so it'd generate less errors when running it throught w3's HTML validator. Couldn't check it because I don't have any working webspace, so Dries, upload it and I'll check, I am pretty certain that it'll solve a whole lot of errors, since I fixed a bug in story... story being generated about ten times in the HTML code on drop's main page. I expect about 30 errors less...

Jeroen.

P.S.: I don't think I'll get unconed.theme and marvin.theme updated today. But I promise I'll do it tomorrow. Had to go eat with my family, just got back and in 2 hours I am leavin for the movies. Hope you don't mind, but it's always cooler to commit patches closer to the release date... gives you this "rush" feeling. Ahh, deliberately doing stuff on  the nick of time... sweet :)

- applied David Norman's patch to turn all <?'s into fully qualified
  <?php's.

I think you all read the mail about what has changed, I also did the tiny abstract/Editor's note update. :)

Jeroen.

- fixed two-side-bar-theme-bug-with-latest-headlines

- more small improvements

- a couple of small improvements

- some important changes to our theme API which can be summerized as:

     abstract() + article() = story()

  abstract() and article() have been merged into a new function story()
  which looks like:

  function story($story_object, $reply) {
    if (!reply) {
       // full story
    }
    else {
       // main page version / abstract
    }
  }

  This should allow you to "compress" your theme as abstract() and
  article() tended to be 98% identical.

  => I didn't really merge your themes so I leave it up to *you* to
     improved the code!!! Do it ASAP as we release drupal 2.00 in 7
     days.

  In future we'll have similar functions for other content types as
  for example:

     review($review, $reply);
     enquete($enquete, $reply);
     ...

A rather large and important update:

revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)

    $host -> $url[host]

Oh, yes, I remember, I took away the drop META tags as Dries requested, also I changed the ALT="drop.org logo" to ALT="". But Dries, I can't make everything drop independant. Since I work with the random logo's...
Also removed a style tag that I didn't use.

Jeroen.

Has he gone insane! No. I just (but that's just my opinion) made a major improvement to my theme. In one of my unentertained moments I often just browse to drop and stare at my theme for a while. ;) Then I saw that the border around my boxes was 2 pixels wide and grey. Cool. But I thought, let's try it the same way as I do the stories. With a slick 1 pixel wide black border. And so I did. And I admit, it just looks a whole lot better, slicker, smoother, professional. You probably won't notice it at all, and probably no-one would notice. But again, I'd advise you to take a look at http://jeroen.drop.org and look at the boxes before Dries updates these .gifs. Another thing, Unconed, you probably know more or this. What do you think I should use for my images? .gif or .png. What's the advantage of .png, and most of all, is it smaller in size?

Jeroen.

P.S.: another jeroen.theme is coming up. Don't even know what I changed anymore but I changed something...

I updated some things, remove some PHP lines in the comment function, that I think weren't necessary (did that in the previous commit but forgot to mention it) also I renamed all the PHP?> tags to ?>. I read in the docs at http://php.net that this is the way to go. Also I renamed all <? to <?PHP. I added a BCGOLOR again, so my theme's build up is a little nicer again. Spotted four (yes 4) bugs. I now use regular HTML to assign colors but in abstract and article, the sections were still done the old way. Fixed that now, but left them black. Oh yeah, I fixed that weird rendering of my theme I think Dries was talking about. He didn't exactly mention what was wrong but I assume that it were the links in abstract and article that didn't display at the right of the story. Because I deleted some tables I had to add COLSPAN="2". However, when I loaded my page locally on eden it displayed correct. But when I browsed to drop it didn't (in the same browser) Do you get it? I sure don't. It was the same HTML code, but seems differently parsed when coming from an outside server. Allthough I don't see why Netscape would see apache locally as something different than another one. Nevertheless, I think it's fixed.

Jeroen.

I tweaked my theme a bit, don't know if it'll help much but I was able to squeeze a table out of abstract and article. So what you'd say? Well, since the abstract function is called for every post on the main page, I thought that it'd improve it a bit. Of course it isn't much but less tables to show the same is always a good thing. Also, due of the deleted table, I could delete some backgrounds (less traffic from the server to the client) and placed them once in a TABLE header. OK, but a cool side-effect is that it's more HTML 4.01 compliant. Because BACKGROUNDs are allowed in TABLEs and I think it's a bit unclear if they can be in TD yes or no. Either way, this brought to my attention that my !DOCTYPE is strict... I started of strict though... But I think it's a better idea to switch to transitional/loose. OK I think that was it... Oh also because of the changed TABLE structure I had to delete some BGCOLORs. Again, it might be a teeny weeny bit faster, but when you see my site being build up it isn't that nice anymore. (bgcolors are displayed faster than backgrounds). Nevertheless its the result that counts not? Let's hope everything still works.

Jeroen.

- various smaller updates before I start watching Formula 1 with [a] a
  0.5 liter box of Haagen-Dhaz (Belgian Choclate) and [b] my laptop on
  my lap for drupal hacking.  Life hardly can get any better than this.

- added a new faq module with administration interface

code revision:
 - shortened and improved the code

code revision:
   - fixed a "visual-quote-glitch", i.e. a missing stripslashes()