summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Pott2018-09-12 12:27:01 (GMT)
committerAlex Pott2018-09-12 12:27:08 (GMT)
commit917f75bc59a274edfac0fd6ba3d6719a54c97ec4 (patch)
tree9e71895ec9347b97005458d275b68c84f63cd3f8
parent4390dc6b925ff87373715cef34f5dba2c71f7a57 (diff)
Issue #2887134 by Mile23, nlisgo, naveenvalecha, Lendude: Convert web tests to browser tests for taxonomy module Part -2
(cherry picked from commit 954795908191e317f029f5cf79e6125ae03d11b8)
-rw-r--r--core/modules/taxonomy/tests/src/Functional/RssTest.php (renamed from core/modules/taxonomy/src/Tests/RssTest.php)8
-rw-r--r--core/modules/taxonomy/tests/src/Functional/TaxonomyTermIndentationTest.php (renamed from core/modules/taxonomy/src/Tests/TaxonomyTermIndentationTest.php)31
-rw-r--r--core/modules/taxonomy/tests/src/Functional/TermAutocompleteTest.php (renamed from core/modules/taxonomy/src/Tests/TermAutocompleteTest.php)40
-rw-r--r--core/modules/taxonomy/tests/src/Functional/TermTest.php (renamed from core/modules/taxonomy/src/Tests/TermTest.php)38
-rw-r--r--core/modules/taxonomy/tests/src/Functional/TermTranslationTest.php (renamed from core/modules/taxonomy/src/Tests/TermTranslationTest.php)4
5 files changed, 89 insertions, 32 deletions
diff --git a/core/modules/taxonomy/src/Tests/RssTest.php b/core/modules/taxonomy/tests/src/Functional/RssTest.php
index c4f4884..2f22196 100644
--- a/core/modules/taxonomy/src/Tests/RssTest.php
+++ b/core/modules/taxonomy/tests/src/Functional/RssTest.php
@@ -1,6 +1,6 @@
<?php
-namespace Drupal\taxonomy\Tests;
+namespace Drupal\Tests\taxonomy\Functional;
use Drupal\Core\Field\FieldStorageDefinitionInterface;
use Drupal\views\Views;
@@ -106,7 +106,11 @@ class RssTest extends TaxonomyTestBase {
// Test that the feed page exists for the term.
$this->drupalGet("taxonomy/term/{$term1->id()}/feed");
- $this->assertTrue(!empty($this->cssSelect('rss[version="2.0"]')), "Feed page is RSS.");
+ $assert = $this->assertSession();
+ $assert->responseHeaderContains('Content-Type', 'application/rss+xml');
+ // Ensure the RSS version is 2.0.
+ $rss_array = $this->getSession()->getDriver()->find('rss');
+ $this->assertEquals('2.0', reset($rss_array)->getAttribute('version'));
// Check that the "Exception value" is disabled by default.
$this->drupalGet('taxonomy/term/all/feed');
diff --git a/core/modules/taxonomy/src/Tests/TaxonomyTermIndentationTest.php b/core/modules/taxonomy/tests/src/Functional/TaxonomyTermIndentationTest.php
index 599b6fb..13dcb7e 100644
--- a/core/modules/taxonomy/src/Tests/TaxonomyTermIndentationTest.php
+++ b/core/modules/taxonomy/tests/src/Functional/TaxonomyTermIndentationTest.php
@@ -1,6 +1,6 @@
<?php
-namespace Drupal\taxonomy\Tests;
+namespace Drupal\Tests\taxonomy\Functional;
/**
* Ensure that the term indentation works properly.
@@ -33,6 +33,7 @@ class TaxonomyTermIndentationTest extends TaxonomyTestBase {
* Tests term indentation.
*/
public function testTermIndentation() {
+ $assert = $this->assertSession();
// Create three taxonomy terms.
$term1 = $this->createTerm($this->vocabulary);
$term2 = $this->createTerm($this->vocabulary);
@@ -42,15 +43,23 @@ class TaxonomyTermIndentationTest extends TaxonomyTestBase {
$taxonomy_storage = $this->container->get('entity.manager')->getStorage('taxonomy_term');
// Indent the second term under the first one.
- $edit = [
+ $this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary->get('vid') . '/overview');
+ $hidden_edit = [
'terms[tid:' . $term2->id() . ':0][term][tid]' => 2,
'terms[tid:' . $term2->id() . ':0][term][parent]' => 1,
'terms[tid:' . $term2->id() . ':0][term][depth]' => 1,
+ ];
+ // Because we can't post hidden form elements, we have to change them in
+ // code here, and then submit.
+ foreach ($hidden_edit as $field => $value) {
+ $node = $assert->hiddenFieldExists($field);
+ $node->setValue($value);
+ }
+ $edit = [
'terms[tid:' . $term2->id() . ':0][weight]' => 1,
];
-
// Submit the edited form and check for HTML indentation element presence.
- $this->drupalPostForm('admin/structure/taxonomy/manage/' . $this->vocabulary->get('vid') . '/overview', $edit, t('Save'));
+ $this->drupalPostForm(NULL, $edit, t('Save'));
$this->assertPattern('|<div class="js-indentation indentation">&nbsp;</div>|');
// Check explicitly that term 2's parent is term 1.
@@ -58,14 +67,22 @@ class TaxonomyTermIndentationTest extends TaxonomyTestBase {
$this->assertEqual(key($parents), 1, 'Term 1 is the term 2\'s parent');
// Move the second term back out to the root level.
- $edit = [
+ $this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary->get('vid') . '/overview');
+ $hidden_edit = [
'terms[tid:' . $term2->id() . ':0][term][tid]' => 2,
'terms[tid:' . $term2->id() . ':0][term][parent]' => 0,
'terms[tid:' . $term2->id() . ':0][term][depth]' => 0,
+ ];
+ // Because we can't post hidden form elements, we have to change them in
+ // code here, and then submit.
+ foreach ($hidden_edit as $field => $value) {
+ $node = $assert->hiddenFieldExists($field);
+ $node->setValue($value);
+ }
+ $edit = [
'terms[tid:' . $term2->id() . ':0][weight]' => 1,
];
-
- $this->drupalPostForm('admin/structure/taxonomy/manage/' . $this->vocabulary->get('vid') . '/overview', $edit, t('Save'));
+ $this->drupalPostForm(NULL, $edit, t('Save'));
// All terms back at the root level, no indentation should be present.
$this->assertNoPattern('|<div class="js-indentation indentation">&nbsp;</div>|');
diff --git a/core/modules/taxonomy/src/Tests/TermAutocompleteTest.php b/core/modules/taxonomy/tests/src/Functional/TermAutocompleteTest.php
index ce28b12..6304976 100644
--- a/core/modules/taxonomy/src/Tests/TermAutocompleteTest.php
+++ b/core/modules/taxonomy/tests/src/Functional/TermAutocompleteTest.php
@@ -1,7 +1,8 @@
<?php
-namespace Drupal\taxonomy\Tests;
+namespace Drupal\Tests\taxonomy\Functional;
+use Drupal\Component\Serialization\Json;
use Drupal\Core\Entity\Entity\EntityFormDisplay;
use Drupal\Core\Entity\Entity\EntityViewDisplay;
use Drupal\Core\Field\FieldStorageDefinitionInterface;
@@ -16,6 +17,13 @@ use Drupal\field\Entity\FieldStorageConfig;
class TermAutocompleteTest extends TaxonomyTestBase {
/**
+ * Modules to enable.
+ *
+ * @var array
+ */
+ public static $modules = ['node'];
+
+ /**
* The vocabulary.
*
* @var \Drupal\taxonomy\Entity\Vocabulary
@@ -127,7 +135,25 @@ class TermAutocompleteTest extends TaxonomyTestBase {
// Retrieve the autocomplete url.
$this->drupalGet('node/add/article');
$result = $this->xpath('//input[@name="' . $this->fieldName . '[0][target_id]"]');
- $this->autocompleteUrl = $this->getAbsoluteUrl($result[0]['data-autocomplete-path']);
+ $this->autocompleteUrl = $this->getAbsoluteUrl($result[0]->getAttribute('data-autocomplete-path'));
+ }
+
+ /**
+ * Helper function for JSON formatted requests.
+ *
+ * @param string|\Drupal\Core\Url $path
+ * Drupal path or URL to load into Mink controlled browser.
+ * @param array $options
+ * (optional) Options to be forwarded to the url generator.
+ * @param string[] $headers
+ * (optional) An array containing additional HTTP request headers.
+ *
+ * @return string[]
+ * Array representing decoded JSON response.
+ */
+ protected function drupalGetJson($path, array $options = [], array $headers = []) {
+ $options = array_merge_recursive(['query' => ['_format' => 'json']], $options);
+ return Json::decode($this->drupalGet($path, $options, $headers));
}
/**
@@ -137,21 +163,21 @@ class TermAutocompleteTest extends TaxonomyTestBase {
*/
public function testAutocompleteCountResults() {
// Test that no matching term found.
- $data = $this->drupalGetJSON(
+ $data = $this->drupalGetJson(
$this->autocompleteUrl,
['query' => ['q' => 'zzz']]
);
$this->assertTrue(empty($data), 'Autocomplete returned no results');
// Test that only one matching term found, when only one matches.
- $data = $this->drupalGetJSON(
+ $data = $this->drupalGetJson(
$this->autocompleteUrl,
['query' => ['q' => 'aaa 10']]
);
$this->assertEqual(1, count($data), 'Autocomplete returned 1 result');
// Test the correct number of matches when multiple are partial matches.
- $data = $this->drupalGetJSON(
+ $data = $this->drupalGetJson(
$this->autocompleteUrl,
['query' => ['q' => 'aaa 1']]
);
@@ -159,7 +185,7 @@ class TermAutocompleteTest extends TaxonomyTestBase {
// Tests that only 10 results are returned, even if there are more than 10
// matches.
- $data = $this->drupalGetJSON(
+ $data = $this->drupalGetJson(
$this->autocompleteUrl,
['query' => ['q' => 'aaa']]
);
@@ -192,7 +218,7 @@ class TermAutocompleteTest extends TaxonomyTestBase {
];
}
- $data = $this->drupalGetJSON(
+ $data = $this->drupalGetJson(
$this->autocompleteUrl,
['query' => ['q' => 'bbb']]
);
diff --git a/core/modules/taxonomy/src/Tests/TermTest.php b/core/modules/taxonomy/tests/src/Functional/TermTest.php
index 54309c4..cce58da 100644
--- a/core/modules/taxonomy/src/Tests/TermTest.php
+++ b/core/modules/taxonomy/tests/src/Functional/TermTest.php
@@ -1,6 +1,6 @@
<?php
-namespace Drupal\taxonomy\Tests;
+namespace Drupal\Tests\taxonomy\Functional;
use Drupal\Component\Utility\Tags;
use Drupal\Core\Field\FieldStorageDefinitionInterface;
@@ -389,6 +389,7 @@ class TermTest extends TaxonomyTestBase {
* Save, edit and delete a term using the user interface.
*/
public function testTermReorder() {
+ $assert = $this->assertSession();
$this->createTerm($this->vocabulary);
$this->createTerm($this->vocabulary);
$this->createTerm($this->vocabulary);
@@ -406,21 +407,30 @@ class TermTest extends TaxonomyTestBase {
// "tid:1:0[depth]", and "tid:1:0[weight]". Change the order to term2,
// term3, term1 by setting weight property, make term3 a child of term2 by
// setting the parent and depth properties, and update all hidden fields.
- $edit = [
+ $hidden_edit = [
'terms[tid:' . $term2->id() . ':0][term][tid]' => $term2->id(),
'terms[tid:' . $term2->id() . ':0][term][parent]' => 0,
'terms[tid:' . $term2->id() . ':0][term][depth]' => 0,
- 'terms[tid:' . $term2->id() . ':0][weight]' => 0,
'terms[tid:' . $term3->id() . ':0][term][tid]' => $term3->id(),
'terms[tid:' . $term3->id() . ':0][term][parent]' => $term2->id(),
'terms[tid:' . $term3->id() . ':0][term][depth]' => 1,
- 'terms[tid:' . $term3->id() . ':0][weight]' => 1,
'terms[tid:' . $term1->id() . ':0][term][tid]' => $term1->id(),
'terms[tid:' . $term1->id() . ':0][term][parent]' => 0,
'terms[tid:' . $term1->id() . ':0][term][depth]' => 0,
+ ];
+ // Because we can't post hidden form elements, we have to change them in
+ // code here, and then submit.
+ foreach ($hidden_edit as $field => $value) {
+ $node = $assert->hiddenFieldExists($field);
+ $node->setValue($value);
+ }
+ // Edit non-hidden elements within drupalPostForm().
+ $edit = [
+ 'terms[tid:' . $term2->id() . ':0][weight]' => 0,
+ 'terms[tid:' . $term3->id() . ':0][weight]' => 1,
'terms[tid:' . $term1->id() . ':0][weight]' => 2,
];
- $this->drupalPostForm(NULL, $edit, t('Save'));
+ $this->drupalPostForm(NULL, $edit, 'Save');
$taxonomy_storage->resetCache();
$terms = $taxonomy_storage->loadTree($this->vocabulary->id());
@@ -570,7 +580,7 @@ class TermTest extends TaxonomyTestBase {
];
// Create the term.
- $this->drupalPostForm('admin/structure/taxonomy/manage/' . $this->vocabulary->id() . '/add', $edit, t('Save'));
+ $this->drupalPostForm('admin/structure/taxonomy/manage/' . $this->vocabulary->id() . '/add', $edit, 'Save');
$terms = taxonomy_term_load_multiple_by_name($edit['name[0][value]']);
$term = reset($terms);
@@ -578,19 +588,19 @@ class TermTest extends TaxonomyTestBase {
// Check the breadcrumb on the term edit page.
$this->drupalGet('taxonomy/term/' . $term->id() . '/edit');
- $breadcrumbs = $this->cssSelect('nav.breadcrumb ol li a');
+ $breadcrumbs = $this->getSession()->getPage()->findAll('css', 'nav.breadcrumb ol li a');
$this->assertIdentical(count($breadcrumbs), 2, 'The breadcrumbs are present on the page.');
- $this->assertIdentical((string) $breadcrumbs[0], 'Home', 'First breadcrumb text is Home');
- $this->assertIdentical((string) $breadcrumbs[1], $term->label(), 'Second breadcrumb text is term name on term edit page.');
- $this->assertEscaped((string) $breadcrumbs[1], 'breadcrumbs displayed and escaped.');
+ $this->assertIdentical($breadcrumbs[0]->getText(), 'Home', 'First breadcrumb text is Home');
+ $this->assertIdentical($breadcrumbs[1]->getText(), $term->label(), 'Second breadcrumb text is term name on term edit page.');
+ $this->assertEscaped($breadcrumbs[1]->getText(), 'breadcrumbs displayed and escaped.');
// Check the breadcrumb on the term delete page.
$this->drupalGet('taxonomy/term/' . $term->id() . '/delete');
- $breadcrumbs = $this->cssSelect('nav.breadcrumb ol li a');
+ $breadcrumbs = $this->getSession()->getPage()->findAll('css', 'nav.breadcrumb ol li a');
$this->assertIdentical(count($breadcrumbs), 2, 'The breadcrumbs are present on the page.');
- $this->assertIdentical((string) $breadcrumbs[0], 'Home', 'First breadcrumb text is Home');
- $this->assertIdentical((string) $breadcrumbs[1], $term->label(), 'Second breadcrumb text is term name on term delete page.');
- $this->assertEscaped((string) $breadcrumbs[1], 'breadcrumbs displayed and escaped.');
+ $this->assertIdentical($breadcrumbs[0]->getText(), 'Home', 'First breadcrumb text is Home');
+ $this->assertIdentical($breadcrumbs[1]->getText(), $term->label(), 'Second breadcrumb text is term name on term delete page.');
+ $this->assertEscaped($breadcrumbs[1]->getText(), 'breadcrumbs displayed and escaped.');
}
}
diff --git a/core/modules/taxonomy/src/Tests/TermTranslationTest.php b/core/modules/taxonomy/tests/src/Functional/TermTranslationTest.php
index ccb16f6..bd90850 100644
--- a/core/modules/taxonomy/src/Tests/TermTranslationTest.php
+++ b/core/modules/taxonomy/tests/src/Functional/TermTranslationTest.php
@@ -1,9 +1,9 @@
<?php
-namespace Drupal\taxonomy\Tests;
+namespace Drupal\Tests\taxonomy\Functional;
use Drupal\Core\Url;
-use Drupal\system\Tests\Menu\AssertBreadcrumbTrait;
+use Drupal\Tests\system\Functional\Menu\AssertBreadcrumbTrait;
/**
* Tests for proper breadcrumb translation.