summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeroen Bensch2001-03-05 13:56:41 (GMT)
committerJeroen Bensch2001-03-05 13:56:41 (GMT)
commit830e9b3f4f011640047e6607af79347668ea3040 (patch)
tree5e6ea0fa3f737f100af39a995f9e5aa3f489b27d
parentd684b1f10aecc3403a8ec97d45118f67883480e5 (diff)
Hi all,
I tweaked my theme a bit, don't know if it'll help much but I was able to squeeze a table out of abstract and article. So what you'd say? Well, since the abstract function is called for every post on the main page, I thought that it'd improve it a bit. Of course it isn't much but less tables to show the same is always a good thing. Also, due of the deleted table, I could delete some backgrounds (less traffic from the server to the client) and placed them once in a TABLE header. OK, but a cool side-effect is that it's more HTML 4.01 compliant. Because BACKGROUNDs are allowed in TABLEs and I think it's a bit unclear if they can be in TD yes or no. Either way, this brought to my attention that my !DOCTYPE is strict... I started of strict though... But I think it's a better idea to switch to transitional/loose. OK I think that was it... Oh also because of the changed TABLE structure I had to delete some BGCOLORs. Again, it might be a teeny weeny bit faster, but when you see my site being build up it isn't that nice anymore. (bgcolors are displayed faster than backgrounds). Nevertheless its the result that counts not? Let's hope everything still works. Jeroen.
-rw-r--r--themes/jeroen/jeroen.theme130
1 files changed, 59 insertions, 71 deletions
diff --git a/themes/jeroen/jeroen.theme b/themes/jeroen/jeroen.theme
index 020b66f..39d19a8 100644
--- a/themes/jeroen/jeroen.theme
+++ b/themes/jeroen/jeroen.theme
@@ -17,31 +17,31 @@
PHP?>
- <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">
- <HTML>
-
- <HEAD>
- <TITLE><? echo $site_name; ?> - Tears of technology</TITLE>
- <META NAME="description" CONTENT="drop.org">
- <META NAME="keywords" CONTENT="drop, weblog, portal, community, news, article, announcements, stories, story, computer, science, space, hype, cult, geek, nerd, foo, bar">
- <STYLE type="text/css">
- <!--
- BODY,P,DIV,LI,UL,TD,EM,FONT,BLOCKQUOTE,FORM{font-size: 10pt; font-family:Helvetica,Lucida,sans-serif;}
- SMALL {font-size: 8pt;}
- TD img.pipe {display: block}
- -->
- </STYLE>
- </HEAD>
-
- <BODY TEXT="#202020" BGCOLOR="#FEFEFE" BACKGROUND="themes/jeroen/images/background.gif" ALINK="#000000" LINK="#000000" VLINK="#000000">
- <TABLE WIDTH="100%" ALIGN="left" CELLPADDING="0" CELLSPACING="6" BORDER="0">
- <TR>
- <TD COLSPAN="2" WIDTH="80%">
- <?PHP $img = (rand(0,150) == 75) ? "logo2.gif" : "logo.gif";PHP ?>
- <IMG SRC="themes/jeroen/images/<? echo $img; ?>" ALT="drop.org logo"><BR><BR>
- </TD>
- <TD WIDTH="20%">
-
+ <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+ <HTML>
+
+ <HEAD>
+ <TITLE><? echo $site_name; ?> - Tears of technology</TITLE>
+ <META NAME="description" CONTENT="drop.org">
+ <META NAME="keywords" CONTENT="drop, weblog, portal, community, news, article, announcements, stories, story, computer, science, space, hype, cult, geek, nerd, foo, bar">
+ <STYLE type="text/css">
+ <!--
+ BODY,P,DIV,LI,UL,TD,EM,FONT,BLOCKQUOTE,FORM{font-size: 10pt; font-family:Helvetica,Lucida,sans-serif;}
+ SMALL {font-size: 8pt;}
+ TD img.pipe {display: block}
+ -->
+ </STYLE>
+ </HEAD>
+
+ <BODY TEXT="#202020" BGCOLOR="#FEFEFE" BACKGROUND="themes/jeroen/images/background.gif" ALINK="#000000" LINK="#000000" VLINK="#000000">
+ <TABLE WIDTH="100%" ALIGN="left" CELLPADDING="0" CELLSPACING="6" BORDER="0">
+ <TR>
+ <TD COLSPAN="2" WIDTH="80%">
+ <?PHP $img = (rand(0,150) == 75) ? "logo2.gif" : "logo.gif";PHP ?>
+ <IMG SRC="themes/jeroen/images/<? echo $img; ?>" ALT="drop.org logo"><BR><BR>
+ </TD>
+ <TD WIDTH="20%">
+
<?PHP
$this->box("Drop where?", "<TR>
@@ -59,18 +59,18 @@ PHP?>
PHP?>
- </TD>
- </TR>
- <TR>
- <TD VALIGN="top" ALIGN="right">
+ </TD>
+ </TR>
+ <TR>
+ <TD VALIGN="top" ALIGN="right">
<?PHP
theme_blocks("left", $this);
PHP?>
- </TD>
- <TD WIDTH="80%" VALIGN="top" ALIGN="left">
+ </TD>
+ <TD WIDTH="80%" VALIGN="top" ALIGN="left">
<?PHP
@@ -95,7 +95,7 @@ PHP?>
<TABLE BORDER="0" CELLPADDING="1" CELLSPACING="0" BGCOLOR="#000000" WIDTH="100%">
<TR>
<TD>
- <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%">
+ <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%" BACKGROUND="themes/jeroen/images/sketch.gif">
<TR>
<TD ALIGN="left" BACKGROUND="themes/jeroen/images/menutitle.gif" NOWRAP>
<FONT COLOR="#FEFEFE">
@@ -123,27 +123,21 @@ PHP?>
</TD>
</TR>
<TR>
- <TD COLSPAN="2" VALIGN="top" WIDTH="100%" BGCOLOR="#E7E7E7" BACKGROUND="themes/jeroen/images/sketch.gif">
- <TABLE WIDTH="100%">
- <TR>
- <TD>
+ <TD COLSPAN="2" VALIGN="top" WIDTH="100%">
<?PHP
-
- if ($story->updates)
- echo "<P><FONT COLOR=\"#E09226\">". t("Editor's note") .":</FONT>". check_output($story->updates, 1) ."</P>";
- if ($story->abstract)
- echo "<P>". check_output($story->abstract, 1) ."</P>";
+
+ if ($story->updates)
+ echo "<P><FONT COLOR=\"#E09226\">". t("Editor's note") .":</FONT>". check_output($story->updates, 1) ."</P>";
+ if ($story->abstract)
+ echo "<P>". check_output($story->abstract, 1) ."</P>";
PHP?>
- </TD>
- </TR>
- <TR>
- <TD ALIGN="right">
- <FONT COLOR="#E09226"><? echo theme_morelink($this, $story); ?></FONT>
- </TD>
- </TR>
- </TABLE>
+ </TD>
+ </TR>
+ <TR>
+ <TD ALIGN="right">
+ <FONT COLOR="#E09226"><? echo theme_morelink($this, $story); ?></FONT>
</TD>
</TR>
</TABLE>
@@ -178,7 +172,7 @@ PHP?>
<TABLE BORDER="0" CELLPADDING="1" CELLSPACING="0" BGCOLOR="#000000" WIDTH="100%">
<TR>
<TD>
- <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%">
+ <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%" BACKGROUND="themes/jeroen/images/sketch.gif">
<TR>
<TD ALIGN="left" BACKGROUND="themes/jeroen/images/menutitle.gif" NOWRAP>
<FONT COLOR="#FEFEFE">
@@ -216,30 +210,24 @@ PHP?>
</TD>
</TR>
<TR>
- <TD COLSPAN="2" VALIGN="top" WIDTH="100%" BGCOLOR="#E7E7E7" BACKGROUND="themes/jeroen/images/sketch.gif">
- <TABLE WIDTH="100%">
- <TR>
- <TD>
+ <TD COLSPAN="2" VALIGN="top" WIDTH="100%">
<?PHP
- if ($story->updates)
- echo "<P>check_output($story->abstract, 1)</P><P><FONT COLOR=\"#E09226\">Editor's note by <A HREF=\"account.php?op=userinfo&uname=$story->editor\">$story->editor</A>:</FONT>$story->updates</P>";
- else
- echo check_output($story->abstract, 1);
- if ($story->article)
- echo "<P>". check_output($story->article, 1) ."</P>";
+ if ($story->updates)
+ echo "<P>check_output($story->abstract, 1)</P><P><FONT COLOR=\"#E09226\">Editor's note by <A HREF=\"account.php?op=userinfo&uname=$story->editor\">$story->editor</A>:</FONT>$story->updates</P>";
+ else
+ echo check_output($story->abstract, 1);
+ if ($story->article)
+ echo "<P>". check_output($story->article, 1) ."</P>";
PHP?>
- </TD>
- </TR>
- <TR>
- <TD ALIGN="right">
- <FONT COLOR="#E09226"><? echo $reply; ?></FONT>
- </TD>
- </TR>
- </TABLE>
+ </TD>
+ </TR>
+ <TR>
+ <TD ALIGN="right">
+ <FONT COLOR="#E09226"><? echo $reply; ?></FONT>
</TD>
</TR>
</TABLE>
@@ -269,11 +257,11 @@ PHP?>
echo " <TABLE BORDER=\"0\" CELLPADDING=\"1\" CELLSPACING=\"0\" BGCOLOR=\"#000000\" WIDTH=\"100%\">";
echo " <TR>";
echo " <TD>";
- echo " <TABLE BACKGROUND=\"/themes/jeroen/images/menutitle.gif\" BORDER=\"0\" CELLPADDING=\"2\" CELLSPACING=\"0\" WIDTH=\"100%\">";
+ echo " <TABLE BACKGROUND=\"themes/jeroen/images/menutitle.gif\" BORDER=\"0\" CELLPADDING=\"2\" CELLSPACING=\"0\" WIDTH=\"100%\">";
echo " <TR>";
echo " <TD>";
- echo " <TABLE BORDER=\"0\" CELLPADDING=\"2\" CELLSPACING=\"0\"WIDTH=\"100%\">";
-
+ echo " <TABLE BORDER=\"0\" CELLPADDING=\"2\" CELLSPACING=\"0\" WIDTH=\"100%\">";
+
// Subject:
echo " <TR>";
echo " <TD ALIGN=\"right\" WIDTH=\"5%\">";