#457 remove optional core_version_requirement key from test modules, fix incorrect package information

Based on https://www.drupal.org/node/3070687#test.

Skip CompleteDynamicPropertiesRector rule that causes 4 false positives.

Use a PHPStan job using max PHP version, add some missing types, set PHPStan level 3, fix all of the PHPStan level 3 errors, numerate assertion messages in testDumpersOutput().

Increase PHPStan to level 1, fix all "variable might be unsigned" errors, remove redundant argument from constructor, improve generating menus test coverage, adjust formatting.

mscieszka authored Mar 30, 2024 and mscieszka committed Mar 30, 2024

PostIncDecToPreIncDecRector rule.

mscieszka authored Mar 30, 2024 and mscieszka committed Mar 30, 2024

EncapsedStringsToSprintfRector rule.

Fixes PHPStan's "Plugin definitions cannot be altered" error.

Inject the entity field manager service in DevelGenerateBase as it is used in several DevelGenerate plugins.

Move the logic that adds comments and statistics from the devel_generate.module's 'hook_entity_insert' implementation to ContentDevelGenerate as it was used for node generation.

Change approach to not override constructors in devel_generate plugins.

use dependency injection wherever possible, replace non-extent `\Drupal\Core\Datetime\TimeInterface` with `\Drupal\Component\Datetime\TimeInterface`, make type hints for variables more specific (e.g. `UserStorageInterface` instead of `EntityStorageInterface`), move optional arguments to the end, add some missing types, restore the `DrupalPractice.Objects.GlobalClass.GlobalClass` sniff as it now passes.

Changes come from rules: RemoveUnusedVariableInCatchRector, ClassOnThisVariableObjectRector, ClassOnObjectRector, StrStartsWithRector, StrContainsRector, MixedTypeRector

Apply Drupal Rector's RenameClassRector, ProtectedStaticModulesPropertyRector, AddReturnTypeDeclarationRector rules to adjust the codebase based on Drupal Rector's Drupal 8/9/10 deprecation set.

Replace deprecated functions: user_role_names, drupal_theme_rebuild, theme_get_registry, user_roles.

Fix call to deprecated method loadRevision() of class EntityStorageInterface.

Add types, mostly to the drush_generate module, that were not covered by the Rector type coverage rules.

Based on Rector's type coverage level 36, dead code level 40.

Applied Rector's SimplifyUselessVariableRector, RemoveUselessVarTagRector rules to align the codebase with the deadCodeLevel rule set to 40 (max level).

Rector's rules applied: AddArrowFunctionReturnTypeRector, NumericReturnTypeFromStrictScalarReturnsRector, BoolReturnTypeFromStrictScalarReturnsRector, ReturnTypeFromStrictScalarReturnExprRector, ReturnTypeFromReturnDirectArrayRector.

Add missing array return types based on the Rector's ReturnTypeFromStrictNewArrayRector rule.

The changes come from the StringClassNameToClassConstantRector rule.

The changes come from the DirNameFileConstantToDirConstantRector, TernaryToElvisRector rules.

Issue #255: Coding standards - part 2. Exclude failing sniffs. Set phpcs job to fail for new faults.

Jonathan Smith authored May 17, 2020 and Jonathan Smith committed May 17, 2020

Issue #2929385 by vacho, jonathan1055, piggito, Momo4, rafuel92, davidferlay, KondratievaS: Option to set authors for generated content and avoid authored by anonymous user

Jonathan Smith authored May 01, 2020 and Jonathan Smith committed May 01, 2020

Issue #3127750 by jonathan1055, Berdir: Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9