summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStella Power2007-11-19 11:07:05 (GMT)
committer Stella Power2007-11-19 11:07:05 (GMT)
commitd68fcd0ccfe43e2c04d16a9265e0eb0586d8e32d (patch)
treeab306e151363c21e3019a0b6054abf4c0a2362db
parent950d47e31f2d2ddcd6faf156e8559382a9cd97d5 (diff)
#189823 - comment settings are now per node type
-rw-r--r--includes/coder_6x.inc13
-rw-r--r--tests/coder_6x.inc5
2 files changed, 17 insertions, 1 deletions
diff --git a/includes/coder_6x.inc b/includes/coder_6x.inc
index d4ef62c..8b2088f 100644
--- a/includes/coder_6x.inc
+++ b/includes/coder_6x.inc
@@ -216,6 +216,12 @@ function coder_6x_reviews() {
'#source' => 'all',
'#warning_callback' => '_coder_6x_menu_node_add_warning',
),
+ array(
+ '#type' => 'regex',
+ '#value' => '^comment_form_location$|admin\/content\/comment\/settings',
+ '#source' => 'quote',
+ '#warning_callback' => '_coder_6x_comment_form_location_warning',
+ ),
);
$review = array(
'#title' => t('Converting 5.x modules to 6.x'),
@@ -561,3 +567,10 @@ function _coder_6x_menu_node_add_warning() {
'#link' => 'http://drupal.org/node/114774#node_add_summary',
);
}
+
+function _coder_6x_comment_form_location_warning() {
+ return array(
+ '#warning' => t('Comment settings are now per node type.'),
+ '#link' => 'http://drupal.org/node/114774#comment_settings_per_node_type',
+ );
+}
diff --git a/tests/coder_6x.inc b/tests/coder_6x.inc
index 977e167..a841a25 100644
--- a/tests/coder_6x.inc
+++ b/tests/coder_6x.inc
@@ -62,6 +62,9 @@ function _coder_6x_more_tests() {
custom_url_rewrite($url); // not ok
custom_url_rewrite_inbound($url); // ok
+
+ $form_location = variable_get('comment_form_location', COMMENT_FORM_SEPARATE_PAGE); // not ok
+ $form_location = variable_get('comment_form_location_page', COMMENT_FORM_SEPARATE_PAGE); // ok
}
function _coder_6x_test_link_alter($node, &$links) { // an error
@@ -94,7 +97,7 @@ function mymodule_info($field = 0) {
function mymodule_auth($username, $password, $server) {
}
-function mymodule_help($section) {
+function mymodule_help($section) { // not ok
}
function mymodule_help($section, $arg) { // ok